Errors after upgrading to VM 4.2.0.10905

[ViPeS]

Product page has errors after upgrading to VM 4.2.0.10905

Deprecated: Required parameter $htmlIn follows optional parameter $selected in /home/viinis/domains/virtuvinis.lt/public_html/plugins/vmshipment/rules_shipping_advanced/rules_shipping_base.php on line 491

Deprecated: Required parameter $shipCounter follows optional parameter $cart_prices in /home/viinis/domains/virtuvinis.lt/public_html/plugins/vmshipment/rules_shipping_advanced/rules_shipping_base.php on line 515

PS:
Errors were given by a third-party plugin VM Shipment - Advanced Shipping by Rules for VirtueMart, which was not used, but was published.
Removing the plugin solved the problem.

[Milbo]

Thank you, the plugin is now part of the core, fixed.

[man.of.earth]

Advanced Order Numbers ( https://www.open-tools.net/virtuemart/advanced-ordernumbers.html ) would be also a great addition to VM.

[GJC Web Design]

agree - almost always asked by clients why the order/invoice numbers are random and asked for sequential...

[Milbo]

Please use https://extensions.virtuemart.net/shopper-order/orders/automated-numbers-detail

As far as I know it works almost with the same princip as the old ordernumber, but you can also modify a lot others
Username
Name
Password
Shoppernumber
Invoicenumber
Ordernumber

[Milbo]

agree - almost always asked by clients why the order/invoice numbers are random and asked for sequential...

They are not random. They have for security reasons 2 random chars, as far as I know. and both have a sequential number on default core

[MAD King]

Thank you, the plugin is now part of the core, fixed.

What do you mean by that? "the plugin is now part of the core"

I have the same issues. While I could fix line 491, I cannot figure out line 515.

[Milbo]

Both problems are fixed in the core version.

it is now part of the core. A member payed for it. I think a silvermembership. Or gold, it was not that expensive to update the plugin to work with j4, Php8.2 and vm4.0.22.

I wonder about the messages, because both is fixed, by

Code Select Expand


public function plgVmDisplayListFEShipment (VirtueMartCart $cart, $selected, &$htmlIn) {


and

Code Select Expand


function plgVmOnCheckAutomaticSelectedShipment (VirtueMartCart $cart, array $cart_prices, &$shipCounter) {


PS:
Errors were given by a third-party plugin VM Shipment - Advanced Shipping by Rules for VirtueMart, which was not used, but was published.
Removing the plugin solved the problem.

]

Hmm, should be installed unpublished, like the payments. Going to check this.[/code]

[MAD King]

I am still getting this error:

Code Select Expand

Deprecated: Required parameter $shipCounter follows optional parameter $cart_prices in plugins\vmshipment\rules_shipping_advanced\rules_shipping_base.php on line 515


[Milbo]

Code Select Expand


array $cart_prices

That just says it must be an array. Maybe you must remove the array for your php versoin (which one btw).

[MAD King]

PHP 8.0.28

[Milbo]

Hmm, Does it work for you, if you remove the "array" from the seconed parameter?

[MAD King]

Hmm, Does it work for you, if you remove the "array" from the seconed parameter?

I am not a programmer.
How do I remove that and with what do I have to replace it?

[Milbo]

Code Select Expand


function plgVmOnCheckAutomaticSelectedShipment (VirtueMartCart $cart, array $cart_prices, &$shipCounter) {


So just

Code Select Expand


function plgVmOnCheckAutomaticSelectedShipment (VirtueMartCart $cart, $cart_prices, &$shipCounter) {


[MAD King]

The code I have currently in under line 515 is this

Code Select Expand

function plgVmOnCheckAutomaticSelectedShipment (VirtueMartCart $cart, array $cart_prices = array(), &$shipCounter) {

There are two arrays in it.