How to update Fancybox?

[d0ublezer0]

JUI Jquery 3.1 override works well by template overriding

Code Select Expand

templates\my-template\js\jui\jquery.min.js
But VM fancybox is too old for new version of Jquery
how to update jquery.fancybox-1.3.4.pack.js ?
version 3 is already out: https://fancyapps.com/fancybox/3/
if i overwrite them with new version - it will be overwritten on next update

[Ghost]

Fancybox can be overriden too. Place overrides in:

Code Select Expand

templates/your_template/js/fancybox/jquery.fancybox-1.3.4.pack.js

and

Code Select Expand

templates/your_template/css/jquery.fancybox-1.3.4.css

Just be aware that new versions may not work properly with VM.

[d0ublezer0]

i did.
will be overwritten on update
this add costs to supporting it

[Jörgen]

Did You try Ghost suggestion ? Should not be overwritten IMHO.

Jörgen @ Kreativ Fotografi

[GJC Web Design]

if its in your template and u don't update your template then no..

Can u report back if the v3 works with VM?

[d0ublezer0]

if its in your template and u don't update your template then no..

Can u report back if the v3 works with VM?

i cannot move scripts to my template because VM have older version built-in. only replacing will help me.

and, yes it works with minimal ajustments:
vmprices.js
comment this:

Code Select Expand

/*
    if (usefancy) {
        jQuery.fancybox.showActivity(); // it is deprecated and not used in v.3
    }
*/

and change this

Code Select Expand

if (usefancy) {
                jQuery.fancybox({
                        "titlePosition": "inside",
                        "transitionIn": "fade",
                        "transitionOut": "fade",
                        "changeFade": "fast",
                        "type": "html",
                        "autoCenter": true,
                        "closeBtn": false,
                        "closeClick": false,
                        "content": txt
                    }
                );
            }
to this

Code Select Expand

if (usefancy) {
                jQuery.fancybox.open(txt);
            }

Also fancybox v 3 supports ajax requests and data filtering: https://fancyapps.com/fancybox/3/docs/#ajax

[GJC Web Design]

Thanks for the feedback

[d0ublezer0]

Should not be overwritten IMHO.

Why do you think so? Obsolete files will come along with the installation kit and then they will be written over the modified ones.

[Jörgen]

You got to be kidding. Why would VM overrite them? The whole idea of overrides is that a normal installation uses the override files instead of the default ones, not trying to override the overrides.

Why do you think so? Obsolete files will come along with the installation kit and then they will be written over the modified ones.

Jörgen @ Kreativ Fotografi

[d0ublezer0]

Jörgen, you probably did not understand me.
Of course, the VM will not change the overrided files.
It will replace files in its component folder:

Code Select Expand

\components\com_virtuemart\assets\js\fancybox\jquery.fancybox-1.3.4.pack.js
and

Code Select Expand

\components\com_virtuemart\assets\css\jquery.fancybox-1.3.4.css
It can not be moved to the template overrides - inclusion of this file has built into the VM core.
so the only working solution is to replace its contents with a new version.

[d0ublezer0]

also, you need some changes in default_images.php for images gallery in fancybox v3:
add 

Code Select Expand

data-fancybox="gallery" data-type="image"
to all images in this file

Code Select Expand

echo $this->product->images[0]->displayMediaThumb("", true, ' rel="vm-additional-images" data-fancybox="gallery" data-type="image" ', true, true, false, $width, $height);

[d0ublezer0]

Found only one problem with rupostel OPC, cannot resolve this:

[d0ublezer0]

The main reason why you need to update this outdated plugin: it does not work with the new version of jquery 3.1
to ensure compatibility of new and old scripts is very expensive. eg owl carousel

[Ghost]

Jörgen, you probably did not understand me.
Of course, the VM will not change the overrided files.
It will replace files in its component folder:

Code Select Expand

\components\com_virtuemart\assets\js\fancybox\jquery.fancybox-1.3.4.pack.js
and

Code Select Expand

\components\com_virtuemart\assets\css\jquery.fancybox-1.3.4.css
It can not be moved to the template overrides - inclusion of this file has built into the VM core.
so the only working solution is to replace its contents with a new version.

You make no sense. If you place new files in locations shown in first post, these files will override VM core files.

[d0ublezer0]

You make no sense. If you place new files in locations shown in first post, these files will override VM core files.

oh, really?
override for any file, not only "views" templates?
so, can you try it by yourself?

Code Select Expand

\templates\your_template\com_virtuemart\assets\js\fancybox\jquery.fancybox-1.3.4.pack.js
not overriden