News:

Looking for documentation? Take a look on our wiki

Main Menu

Subtotal incorrect on My Orders page orderconfirmation! How to erase it?

Started by amymattian, December 11, 2012, 14:41:58 PM

Previous topic - Next topic

amymattian

Hi,

how to fix incorrect subtotal that is visible to clients on My orders page. I don't know yet if the same is visible on the order-confirmation since haven't tested that yet, but I would imagine the same bug is there.



There is a Subtotal price that is the Brutto-sum - tax (from netto sum). So f.ex. in the sample the brutto amount is 232e (Without the reduction) and the final tax (from reduced price) is 31,41€ so the My orders page calculates 232e - 31,41e and makes this as the subtotal 200,59€. This is ofcause not correct since the tax is from reduced price not from the brutto price.

How to fix this issue?

How in general can we fix the layout for order-confirmation page inside the webpage, and the layouts for emails that clients get for orderconfirmation and invoice?

We do not want to show price without tax in the order-confirmation page and have set in the settings that, but still they are visible on this page. How to remove netto-price from this page? Is there any tutorials anywhere? I don't do coding so would need good instructions to be able to find the pages first. Thanks!

- Anne

bytelord

Production: Joomla 2.5.8 | VM 2.0.14 | PHP 5.3.13
Testing     : Joomla 2.5.8 | VM 2.0.16 | PHP 5.3.8
Testing     : Joomla 2.5.8 |    VM 2.1   | PHP 5.3.8

- Don't Forget to mark thread as solved when it is solved!
- Please do not PM with support questions, use the forum!

amymattian

Hi,

my Virtuemart is 2.0.14. and the latest Joomla 2.5.8.

The site has Yagendoo Showmall Virtuemart2 theme, but according to them their these use Virtuemart default layouts for emails etc. So my question really is where this layout is defined. The whole override is a bit plur for me since I'm not a coder... any help in indentifying this issue would be nice.

- Anne

bytelord

Hello,

You could verify if your template uses overrides for orders by checking the folder joomla_folder/templates/your_joomla_template/html/com_virtuemart/orders/***.php
and
also the folder joomla_folder/templates/your_joomla_template/html/com_virtuemart/invoice/***.php

The invoice folder is for the mail, the order folder is for front view orders for your clients. As you see is different and don't know why your template provider tells your that is related only to mails, but any way. The original files now:

The template files related to orders are located under joomla_root\folder\components\com_virtuemart\views\orders\tmpl\          and take look inside details_items.php and details_order.php
The template files related to invoices/emails are located under joomla_root\folder\components\com_virtuemart\views\invoice\tmpl\    and a look inside invoice_items.php

Now, if you want to make changes and you want to create a template override do as follows (example for details_items.php for orders):

Copy the original file details_items.php from:  joomla_root\folder\components\com_virtuemart\views\orders\tmpl\ 
to here                                                          : joomla_folder/templates/your_joomla_template/html/com_virtuemart/orders/

If the folders are not exist please create them ... if you already use template overrides edit the overridden file.


I believe that is not related to template files, but as you said is located there, so i gave you the information how you can do it. Please first check if you have overrides for that.

Use firebug to examine you site code and css styling: https://forum.virtuemart.net/index.php?topic=102850.0

Template Overrides:
Creating Template overrides: https://forum.virtuemart.net/index.php?topic=98505.0
Template System: https://dev.virtuemart.net/projects/virtuemart/wiki/Hints_for_the_use_of_the_template_system

Regards
Production: Joomla 2.5.8 | VM 2.0.14 | PHP 5.3.13
Testing     : Joomla 2.5.8 | VM 2.0.16 | PHP 5.3.8
Testing     : Joomla 2.5.8 |    VM 2.1   | PHP 5.3.8

- Don't Forget to mark thread as solved when it is solved!
- Please do not PM with support questions, use the forum!

amymattian

Vau, thank you so much Nikos! Will go through your instructions and save it also for future reference! Very clear instructions! Thanks a million!

Greetings,
Anne

bytelord

Production: Joomla 2.5.8 | VM 2.0.14 | PHP 5.3.13
Testing     : Joomla 2.5.8 | VM 2.0.16 | PHP 5.3.8
Testing     : Joomla 2.5.8 |    VM 2.1   | PHP 5.3.8

- Don't Forget to mark thread as solved when it is solved!
- Please do not PM with support questions, use the forum!

amymattian

Hi,

been checking out the files you mentioned and it's all "hebrew" to me... I would like to erase the whole subtotal line from that chart with total. But I see so much code in both or those files that I don't know which lines are that specific subtotal.

I still belive this is a bug in the Virtuemart. I have updated both VM2 and AIO to the latest 2.0.14. and I'm getting the same issue still.

I have made all the discounts as DATax (Reduction after tax) and then - Euros. This way when we define the reduction is 55€ it shows 55€ reduction and the tax calculations are done afterwards (Brutto - reduction = total amount incuding tax). Can this method be the reason for this wrong subtotal? It should not be!

If I want to erase all the subtotal lines from the My orders page what lines do I have to erase? Are they in details.order or details.item file?

Also should I report this issue somewhere in a bugs-report? Where?

Greetings,

- Anne

bytelord

Hello,

The column you are seaching for is under details_order.php around line 41, 76-78, 87 and may be i miss some of them. Also you should correct the invoice file for mail and pdf invoice, the file is invoice_items.php under components\com_virtuemart\views\invoice\tmpl.

But, what concerns me is that the actual issue  is not related to templates as you said, could you please give a better example to understand it - a full calculation one for what is happening? There is an issue that have been fixed in version 2.0.15c (test version do not use it on live site) that fixes the issue when a coupon applied the tax was calculated from the base price before the discount, you describe the same issue for DATax?

Regards
Production: Joomla 2.5.8 | VM 2.0.14 | PHP 5.3.13
Testing     : Joomla 2.5.8 | VM 2.0.16 | PHP 5.3.8
Testing     : Joomla 2.5.8 |    VM 2.1   | PHP 5.3.8

- Don't Forget to mark thread as solved when it is solved!
- Please do not PM with support questions, use the forum!

amymattian

Hi,

here is the calculation of this example:

                              
Product                Pieces     Net Price   Tax 23% from Brutto   Brutto price   Reduction incl. tax   Total Tax     Subtotal without tax   Price with reduction      
1ZOAD14                   1      26,83            6,17                                33,00             0,00                      6,17           26,83                           33,00      
8BL987132051     1     161,79           37,21                              199,00           64,00                     25,24         109,76                          135,00      
Totals                             188,62           43,38                              232,00           64,00                     31,41         136,59                          168,00      
                              
                              
Correct calculation:                              
Subtotal should be      136,59                        
Total tax                        31,41                        
Total Sum with tax      168,00                        
                              
Incorrect calculation:                              
Brutto – netto tax      232 – 31,41 (Brutto price – total tax (This should not be  brutto price but Subtotal without tax price)                        
Total tax                        31,41   OK                     
Total Sum with tax      168,00   OK                     
                              
According to the VM2 template provider they are using layouts from VM2 not their own. There are not template overrides either! I'd be interested to know if anyone else can produce this issue when using DATax reduction on a product!

Best Regards,
Anne

Milbo

hello Anne,

Please use the latest version https://forum.virtuemart.net/index.php?topic=110743.0 , because we worked on this feature. It helps me also very much, if you could create a new screenshot, using english as language and prices like 10 euro
Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

amymattian

Hi Milbo,

we have now 2.0.16 on the site and 2.5.8. But the problem continues. Here is an image (sorry it is not in English but I have translated the fields for you):

http://www.internet-content.net/images/order-confirmation.jpg

Product Price (Cost)    Base price with tax    Product Price (Gross)    Tax    Discount    Total

   227,64 €           282,00 €                   201,00 €                         39,00 €    81,00 €    201,00 €

SubTotal:    243,00 €              39,00 €    81,00 €    201,00 €

the Subtotal is now calculated from (cost price 227,64 + tax from cost price without discount 54,63 - tax from discounted net price 39,00) = 243,00

Note we are also testing how the prices are if we use no decimals in sales-prices. But then even when I define that tax should have 2 decimals the decimals show ,00 all the time. This is not correct since tax should always show decimals. Can I not use no decimals in the sales price and still get the correct tax calculations with decimals as the law requires?

Greetings,
Anne





amymattian

Hi Milbo,

any news of this issue of Wrong Subtotal amount?

I also noticed only now that the Delivery Cost (Toimitusmaksu) line is twice on the page. That is also an extra issue on the Order Details page. Have you noticed this before?

Greetings,
Anne