Compliance issue in classes/ps_userfield.php

[doorknob]

The javascript at lines 505 to 523 causes an xhtml compliance issue. I changed it from:

Code Select Expand

    echo '<script type="text/javascript">
   function showFields( show, fields ) {
    if( fields ) {
var i;
    for (i=0; i<fields.length;i++) {
    if( show ) {
    document.getElementById( fields[i] + \'_div\' ).style.display = \'\';
    document.getElementById( fields[i] + \'_input\' ).style.display = \'\';
    } else {
    document.getElementById( fields[i] + \'_div\' ).style.display = \'none\';
    document.getElementById( fields[i] + \'_input\' ).style.display = \'none\';
    }
    }
    }
   }
   try {
    showFields( document.getElementById( \'register_account\').checked, new Array(\'username\', \'password\', \'password2\') );
   } catch(e){}
   </script>';

to

Code Select Expand

    echo '<script type="text/javascript">
//<![CDATA[
   function showFields( show, fields ) {
    if( fields ) {
var i;
    for (i=0; i<fields.length;i++) {
    if( show ) {
    document.getElementById( fields[i] + \'_div\' ).style.display = \'\';
    document.getElementById( fields[i] + \'_input\' ).style.display = \'\';
    } else {
    document.getElementById( fields[i] + \'_div\' ).style.display = \'none\';
    document.getElementById( fields[i] + \'_input\' ).style.display = \'none\';
    }
    }
    }
   }
   try {
    showFields( document.getElementById( \'register_account\').checked, new Array(\'username\', \'password\', \'password2\') );
   } catch(e){}
   //]]>
   </script>';

to hide the js and the issue was resolved.

Regards
Phil