News:

You may pay someone to create your store, or you visit our seminar and become a professional yourself with the silver certification

Main Menu

Mistake on constant COM_VM_PRICEDISPLAY_CONFIGURED_BY SHOPPERGRPS

Started by sirius, January 20, 2021, 15:18:36 PM

Previous topic - Next topic

sirius

Hi,

I just found that in en-GB.com_virtuemart_config.ini
this constant "COM_VM_PRICEDISPLAY_CONFIGURED_BY SHOPPERGRPS" missing an underscore.

Despite the fact that it still works it shouldn't have a space in it, and should be "COM_VM_PRICEDISPLAY_CONFIGURED_BY_SHOPPERGRPS"

unless I'm mistaken
J3.10.12 | PHP 7.4.33 + APC + memcached + Opcode
VM Prod : 3.8.6 | VM Test : 4.0.12.10777

Jörgen

Joomla 3.9.18
Virtuemart 3.4.x
Olympiantheme Hera (customized)
This reflects current status when viewing old post.

sirius

Yes it is,

because of same mistake (hopefully?) in /administrator/views/config/tmpl/default_priceconfig.php

if($this->shopgrp_price) echo '<tr><td colspan="2">'.vmText::sprintf('COM_VM_PRICEDISPLAY_CONFIGURED_BY SHOPPERGRPS',implode(',',$this->shopgrp_price)).'</td></tr>';

In this case the real constant consider here is only the bold part "COM_VM_PRICEDISPLAY_CONFIGURED_BY SHOPPERGRPS" and this one is unique, so it works.
That's why I have a space at the beginning of the sentence in admin, because of the unused constant part with the space in it.
J3.10.12 | PHP 7.4.33 + APC + memcached + Opcode
VM Prod : 3.8.6 | VM Test : 4.0.12.10777

jjk

Will be corrected in the next release. Thanks for reporting it.
Non-English Shops: Are your language files up to date?
[url="http://virtuemart.net/community/translations"]http://virtuemart.net/community/translations[/url]