VM BE report graph does not consider „completed” orders and products (code 'F')

Started by man.of.earth, December 10, 2019, 15:03:10 PM

Previous topic - Next topic

man.of.earth

Hello developers,

I noticed that in VM cpanel ( /administrator/index.php?option=com_virtuemart&view=virtuemart ), that chart does not also consider the orders and works with the ,,completed" status ('F'), but only ,,shipped" and ,,confirmed by the store" (so not being accurate).
I found the remedy to this, in /administrator/components/com_virtuemart/models/report.php , line 137:
$orderstates = vRequest::getVar ('order_status_code', array('C','S','F'));
instead of
$orderstates = vRequest::getVar ('order_status_code', array('C','S'));
as it is now.

The same situation is in
/administrator/components/com_virtuemart/views/report/view.html.php on line 80:
$orderstates = vRequest::getVar ('order_status_code', array('C','S')); ->
$orderstates = vRequest::getVar ('order_status_code', array('C','S','F'));

and in
/plugins/vmcustom/istraxx_download_simple/istraxx_downloader_simple.php on line 68:
$os_download = array('C','S'); ->
$os_download = array('C','S','F');
The last one is debatable, according to whether the users can download the files [again] (if they have downloads left) after their order has been marked as ,,completed".