Generation of duplicate aliases

[balai]

File: administrator/components/com_virtuemart/helpers/vmtable.php
function checkCreateUnique

This function is called to generate unique aliases when a record is saved.
For example before the product saving:

Code Select Expand

$productTable = $productModel->getTable ('products');
$productTable->checkCreateUnique('#__virtuemart_products_' . VmConfig::$vmlang,'slug');

Though inside the function there is a code that could potentially generate duplicate values.

            

Code Select Expand

if($posNbr = strrpos($this->$name,'-')){
$existingNbr = substr($this->$name,$posNbr+1);

if(is_numeric($existingNbr)){
$existingNbr++;
if($i>10){
$existingNbr = $existingNbr +  rand (1, 9);
}
$this->$name = substr($this->$name,0,$posNbr+1) . $existingNbr;
} else{
$this->$name = $this->$name . '-1';
}
}

That code:

Code Select Expand

$existingNbr++;
if($i>10){
$existingNbr = $existingNbr +  rand (1, 9);
}

The unique key is based on the number returned by the rand (1, 9)
That means that the sum of these 2 numbers  $existingNbr +  rand (1, 9) can return the same value, more than once.

[Studio 42]

For my batch tool, i don't use random. but increment each time and check if the name exist. It's  slower but safe.
The only problem you can have using this. Is if you have all products having same name, eg. if you name it all 'tool', but i think noone set more then 10 time same product name ?
I don't understand why this is used in VM, it's same for Joomla using the date(i think they removed date as alias in Joomla 3)

[balai]

Any update about that?
Is this going to be fixed in a next release?