News:

Looking for documentation? Take a look on our wiki

Main Menu

MultiVariant Bug in Mobile Devices.

Started by sandstorm, November 16, 2016, 23:58:41 PM

Previous topic - Next topic

Milbo

So which urls are in your first dropdown, when the second is set to "Select an option"? There cant be any, you would have to write a fallback. As I said, your thing works for one dropdown, but not for more. It could be interesting to add your way for single dropdowns.
Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

sandstorm

Quote from: Milbo on November 17, 2016, 13:48:58 PM
Sandstorm did you override the customfield.php in sublayouts? There are some changes which refer to mobile devices. Actually I think it is already added vm3.0.18.
You may also load the vm3.0.18.3 and test the "legacy layout" option

Hi Max (& Patrick),
Apologies for not getting back to you sooner, I have been away on vacation, since I sent my original post.
Thanks for looking over this & discussing it.

I have a copy of my site here, which is using 3.0.18 - http://bit.ly/2gDKVoL & although this has the VMuikit theme running, I have also tested this with the theme completely disabled.
I have NOT overridden the customfield.php in sublayouts.

Patrick/Max - Is it worth testing patricks idea in this site, where there are MV's with 1,2 & 3 variants in some products?

Thanks in advance,
Andy
J3.6.4 / PHP7.0.12
VM3.0.16

Studio 42

Hi Andy,
i implemented the changes in your stagin site. And it work with 3 dropdowns, so my code should work in other cases too.

sandstorm

#18
Hi Max/Patrick

I added Patricks code & tested in 2 copies of my site.
1 using VM3.0.16 & my template/theme (as this is a direct copy of my live site) & also tested in another version of the same site that is using VM3.0.18 & no overriding Template/theme.

After clearing all site cache & iOS cache.
I can confirm that products using 1, 2 & 3 MultiVariant Dropdown options work as expected on my iOS device on 1st load, where they did not work before.

I tried adding different combinations, checked URL's & added to cart & all seem to be OK.

1 MV Option - https://www.lowenergysupermarket.com/water-heating/water-services/pipe-insulation/553/climaflex-pipe-insulation-15mm-dia-19mm-thick-les
2 MV Option - https://www.staging2.lowenergysupermarket.com/lighting/type-of-light/led-spotlight/897/led-cob-spot-down-light-with-transformer_black-les
3 MV Option - https://www.staging2.lowenergysupermarket.com/lighting/type-of-light/energy-saving-tube-light/106/fluorescent-tube-lights-t12-or-t8-to-t5-les

Would be nice to see this added to core, as i am holding back updating a few sites because of it :(

Thanks
Andy
J3.6.4 / PHP7.0.12
VM3.0.16

Milbo

Sandstorm it is a mathematical thing. I explained it often.

Your dropdowns are not changing, then it can work. yes. But it is not a general solution. It is like, hmm
yeh the Mercedes got broken and the mechanic gives you a small Golf as replacement.... you can go to work with it, yes, but it is not the Mercedes. It is easier to fix the Mercedes.
Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

Milbo

And the whole team worked on this issue for weeks. The problem was a general one and not connected to MV. There was the general problem that some js did not work properly on mobiles.

one problem was that the script was loaded asynchron, so was just sometimes not available on bad connections. and the other problem was the use of jQuery in jQuery context.

Patrick postet here already old code (router file), so I see your page as some special problem. Maybe a not completed update.
Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

Milbo

When Patrick provides a patch for https://dev.virtuemart.net/svn/virtuemart/branches/com_virtuemart.3.0.12.4

I am pleased to take a look on it and may integrate it. But what he posted is not the whole code.
Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

Studio 42

Hi max,
It's not the whole code, because option need to add the data-url atribute in PHP(check in the staggin2 site variants options.
I can chek to send you the patch for the 3.0.12.4 release, but i don't installed the beta for now.

sandstorm

#23
Quote from: Milbo on November 24, 2016, 15:30:18 PM
It is like, hmm yeh the Mercedes got broken and the mechanic gives you a small Golf as replacement.... you can go to work with it, yes, but it is not the Mercedes. It is easier to fix the Mercedes.
The Mercedes may be broken, But I also like the Golf too. And the Golf is much better than the Lada that I have now with no wheels.

Currently I have websites where customers cant order products if they are using an iPhone.

This test site here has Patricks suggested fix & if you test with iPhone, it works fine;
1 MV Option - https://www.lowenergysupermarket.com/water-heating/water-services/pipe-insulation/553/climaflex-pipe-insulation-15mm-dia-19mm-thick-les
2 MV Option - https://www.staging2.lowenergysupermarket.com/lighting/type-of-light/led-spotlight/897/led-cob-spot-down-light-with-transformer_black-les
3 MV Option - https://www.staging2.lowenergysupermarket.com/lighting/type-of-light/energy-saving-tube-light/106/fluorescent-tube-lights-t12-or-t8-to-t5-les
J3.6.4 / PHP7.0.12
VM3.0.16

Studio 42

Attached patch for Version 3.0.18.5
Note: i only tested it with Virtuemart sample, i thing same should work for generic variant too.