News:

Looking for documentation? Take a look on our wiki

Main Menu

Bug in classes declaration on virtuemart admin files!

Started by poisom, May 30, 2015, 13:08:27 PM

Previous topic - Next topic

poisom

Please make the appropriate fixes because now virtuemart conflicts with some other plugins i use in administrator panel.

So on file:
     /administrator/components/com_virtuemart/views/product/tmpl/product_edit_information.php

line 44
        <input class="required" type="text" class="inputbox"  name="product_name" id="product_name" value="<?php echo $this->product->product_name?>" size="32" maxlength="255" />

should be
        <input class="required inputbox" type="text" name="product_name" id="product_name" value="<?php echo $this->product->product_name?>" size="32" maxlength="255" />

on file:
        /administrator/components/com_virtuemart/views/product/tmpl/product_edit_price.php

line 28
        <table class="adminform" class="productPriceTable">

should be
        <table class="adminform productPriceTable">



You have to use multiple classes inside the class attribute, separated by whitespace and not in different class attribute. This is the W3C HTML5 recommendation.

Please let me know if and when you will implement those fixes!
Thank you!
Joomla 3.4.1 - Virtuemart 3.0.9.4

Milbo

is implemented, I see that as a kind of typo. We all know how it should be, thank you. If you find more, dont hesitate to tell us.
Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

nppsbh

Hi.
Found some more typos

file
/administrator/components/com_virtuemart/views/product/tmpl/product_edit_price.php
line 28
<table class="adminform" class="productPriceTable">

file
/administrator/components/com_virtuemart/views/product/tmpl/product_edit_customer.php
line 45, 46
</div>
</label>

should be
</label>
</div>


line 61
missing </div>

file
/administrator/components/com_virtuemart/views/product/tmpl/product_edit_information.php
line 255 remove </tr>
line 282~291 shouldn't it be inside a table?

file
/administrator/components/com_virtuemart/views/product/tmpl/product_edit_custom.php
line 144 think is missing a closing div

In shop->shop and configuration->configuration there are also some typos

Milbo

Thank you, yepp. Good work,... wow some of these are really old. The "problem" is here the autocorrection of the browsers.
Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/