CustomsFieldOrderDisplay($item,'FE') not working in pdf but works on email

Started by WebStuff, May 06, 2015, 17:55:28 PM

Previous topic - Next topic

WebStuff

Versions
VirtueMart 3.0.8
Joomla! 3.4.1 Stable [ Ember ]
Joomla Platform 13.1.0 Stable

I'm nearly ready for VM3 on J3 just having one annoying problem.
In the file /components/com_virtuemart/views/invoice/tmpl/invoice_items.php line 65 reads:
$product_attribute = VirtueMartModelCustomfields::CustomsFieldOrderDisplay($item,'FE');
This works fine in the email sent to the client, I get a list of custom fields and their values.
It doesn't work in the pdf file attached to the email it is obviously crashing and I am just getting blank after where it should display the custom fields in the pdf.

I've added attached screenshots to show what I mean. I am stumped. Any help greatly appreciated.


VirtueMartModelCustomfields::CustomsFieldOrderDisplay($item,'FE');

Milbo

Which customfield do you use there? It seems you use something there, which is not pdf compatible.

For example, wrong images
Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

WebStuff

Thanks for the response Milbo they are textinput fields via a plugin. I'll have a look at the plugin code and see what I can turn up.

WebStuff

Hi Milbo,
Found where the problem was.
File: /[SITE_ROOT]/administrator/components/com_virtuemart/models/customfields.php
Lines 1235-1248:
if (!empty($productCustom)) {
$otag = ' <span class="product-field-type-' . $productCustom->field_type . '">';
if ($productCustom->field_type == "E") {

$tmp = '';
if (!class_exists ('vmCustomPlugin'))
require(VMPATH_PLUGINLIBS . DS . 'vmcustomplugin.php');
JPluginHelper::importPlugin ('vmcustom');
$dispatcher = JDispatcher::getInstance ();
$dispatcher->trigger ($trigger.'VM3', array(&$product, &$productCustom, &$tmp));
if(!empty($tmp)){
$html .= $otag.$tmp; }
}

Line 1246 is missing a closing span tag and should also have a br tag to keep it consistent with other product-field-types and should read:
$html .= $otag.$tmp.</span><br />;

This solved my problem.


EDIT: Just spotted another post about this saying 3.0.9 update fixes it.