News:

Support the VirtueMart project and become a member

Main Menu

Filenames in fancybox. Intentional act? VM 2.5.5

Started by MarioP, March 26, 2014, 09:10:55 AM

Previous topic - Next topic

MarioP

Hi,
I've just installed the new VM 2.5.5 and I see the fancybox was changed. Above all we finally have the arrows. :) . But one thing is strange for me. When we click on the thumbnail and then on the image on the main position to make it larger, we have filename displaying on the bottom of that full size image. Is that intentional act? Is that necessary? Or there's something wrong?

Milbo

It should be the the file description, actually. But if you use the synchronise command, it is imho filled with the filename. Please test it
Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

MarioP

I used the "synchronize media" and nothing...The same situation. When we have filled 'Displayed image subtitle' or 'Image Alt-Text' field,  that text appears on the bottom of the image, but when we have nothing, the filename is showing up...

MarioP

I've wondered if I correctly understood your reply ( my English is so-so )..I came to conclusion you mean that using synchronize media command triggers my problem. ( at first I understood that I have to use this command to resolve the problem) . So I created new product, uploaded images ... and the same :(
Quote from: MarioP on March 26, 2014, 15:51:04 PM
When we have filled 'Displayed image subtitle' or 'Image Alt-Text' field,  that text appears on the bottom of the image, but when we have nothing, the filename is showing up...
Because of lack of reply on my last post I guess this is only my problem ( not common),  isn't it?

Milbo

We have in the processAction

if(empty($this->file_title) && !empty($file_name)) $this->file_title = $file_name;

So if you do something with your media, like upload a new one, replacing the media or similar, then an empty title is using the filename as fallback. But when you delete the title, it should be removed. You can also change your layout and use displayMediaFull with the 4th parameter set to false.
Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

MarioP

#5
Milbo sorry for wasting your time for things like mine but I still don't understand why it works that way...So let's say I created a new product and:
1. After adding the first image  - ( I have empty 'Displayed image subtitle'). In the FE everything is ok - the file name isn't showing up.
2. After adding second image - in FE file names are showing up on the bottom of the full image size (we click on thumbnail and then on the image on the main position)
File name isn't displaying on the second and the next images when we use arrows to review the images.
Quote from: Milbo on April 04, 2014, 09:28:13 AM
empty title is using the filename as fallback
What is the purpose of that action? Why the filename has to be displaying when 'Displayed image subtitle' field is empty? Filenames sometimes say nothing so why to display them with the images?
Maybe someone else can explain me that action ( in order to not involve Milbo in that case anymore )
Quote from: Milbo on April 04, 2014, 09:28:13 AM
But when you delete the title, it should be removed.
What title should I remove?

Milbo

This fallback is only for uploading a product. I just tested it again, it works exactly as it should.
Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

MarioP


MarioP

By the way. It turned out that the best solution for me is to use template's override for default_images.php. The file is from VM 2.0.20 I believe. With that override all works fine for me.  :)