password required not validating

[GJC Web Design]

Hi

2.0.24

the ($_fld->required ? ' class="required"' : '') is missing (unless there's a reason for it) in administrator/components/com_virtuemart/models/userfields.php ~ line 861

original

Code Select Expand

case 'password':
case 'password2':
$_return['fields'][$_fld->name]['formcode'] = '<input type="password" id="' . $_prefix.$_fld->name . '_field" name="' . $_prefix.$_fld->name . '"  size="30" class="inputbox" />'."\n";
break;

changed to

Code Select Expand

case 'password':
case 'password2':
$_return['fields'][$_fld->name]['formcode'] = '<input type="password" id="' . $_prefix.$_fld->name . '_field" name="' . $_prefix.$_fld->name .'" '.($_fld->required ? ' class="required"' : ''). ' size="30" class="inputbox" />'."\n";
break;

validates nicely now

cheers

[attachment cleanup by admin]

[AH]

Does this not mess up optional registration??

[GJC Web Design]

Could very well 

But I have an ingrained hatred of non registering shops - refuse to build them cos I find the whole concept ridiculous.. so never tested

but then I'm just an old moaner.. 

so in a word I don't know - but many clients ask me why the signup page is such a mix of asterisks, red errors and non red errors
Think it's better to have consistent validation...
this one at least it's all of a piece.. so not a bug - perhaps should be moved (the topic?)

cheers

[AH]

LOL

We have exactly the opposite view of registration.  We want to get customers through to paying asap and as most only visit us once, we let them register if they want to but don't force them.

I will leave the post here though.