Code contribution: Small improvements in view / user / login

[rvbgnu]

Hi,

I am not a DEV team member, but still want to contribute sometimes, even if I am busy with my clients projects (and happy about it ;-). I did not find how to do it simply, so I am just submitting here the file
components/com_virtuemart/views/user/tmpl/login.php (from the latest version 2.0.15b)
There is minor tweaks that I came across while developing for my clients.

Sorry if it the wrong place for that. Please feel free to redirect me to the right place.

Kind regards,
Hervé

[attachment cleanup by admin]

[Milbo]

looks like this should avoid the bug, that people are logged in via vm, but joomla is not correctly recognising it?
You added this <form id="com-form-login", I wonder if it interferes if you have the normal joomla login module enabled.

[rvbgnu]

I don't know if it interferes, no tested actually.
But what I did is to strip the normal Joomla login, with just a template override of
modules/mod_login/tmpl/default.php

that I put into
templates/MY_TEMPLATE_NAME/html/mod_login/default.php

Around line 73:

Code Select Expand

<a href="<?php echo JRoute::_('index.php?option=com_virtuemart&view=user&layout=edit'); // XXX WAS index.php?option=com_users&view=registration ?>">

So that the Joomla registration, without any billing address, is not directly accessible.

On the eCommerce website with hundreds of people per day, I never had an issue reported like "people are logged in via vm, but joomla is not correctly recognising it".
I have one with the registration link not working sometimes, and I am investigating it at present.

Let me know if I can be of any further help.

[Milbo]

Thank you, sounds good.

[rvbgnu]

You're more than welcome Max!

And congratulations to you and Dev team, especially for the hard work implementing MVC and the Joomla template override! VM2 is so great with this!

Kind regards

[Milbo]

Thank you. Do you know that you can even overwrite most virtuemart plugins ? (if they are written that way)

[rvbgnu]

No, I did not, that sounds good too! But what kind of plugin overwrite do you think?
Shipment (not sure if need it, prefer to enhance the default one)?
Custom? Maybe for custom fields and child variants. I struggled with them last May and June, and ended up with the Drop plugin from BanquetTablePro.

Any example to point me to, please?