Breadcrumb Ko in product page

[amlil71]

Hello teams,

i don't know why breadcrumb trail doesn't work in product page of this website : https://www.varlopeshop.com/materiel-de-cuisine/couverts-spatules-en-bois/cuillere-a-miel.html
It works fine in archive page but not in product page..

Thank you for your help.

regards.

[amlil71]

Hello,

anyone to help me ? I don't understand why all path of breadcrumb doesn't work depsite the template i use.

Thank you.

Regards.

[Jumbo!]

You seem to be using sh404SEF on your site, which manages the breadcrumb system. If you want VirtueMart to control the breadcrumb, you must disable sh404SEF.

Breadcrumb entries have nothing to do with any template.

[amlil71]

Thank you Jumbo for your answer, it's appréciated.

I have disabled all plugin from SH404sef and cleared all caches and try again but it seems to not repair the problem.

Regards.

[Studio 42]

Hard to understand. you have to check the product view code and debug the added elements in the breadcrumb
Or perhaps you have disebled the categories in the virtuemart config ?
virtuemart configuration > Seo settings : Use full category tree for product links   

[amlil71]

Merci pour ta réponse.

J'ai du mal à comprendre aussi car j'utilise aussi SH404SEF pour un autre site mais je n'ai pas de souci avec l'affichage du breadcrumb.

Je vais installer le site en local et faire des tests car les tests réalisés en production me cassent le SEO.

Thank you all for your help. I will install the website in local and try to debug the problem.

have a nice day.

Regards.

[amlil71]

I have found the solution,

i have installed this view.html.php on /components/com_virtuemart/views/productdetails folder and now it's work.

Code Select Expand



<?php

/**
 *
 * Product details view
 *
 * @package VirtueMart
 * @subpackage
 * @author RolandD
 * @link https://virtuemart.net
 * @copyright Copyright (c) 2004 - 2010 VirtueMart Team. All rights reserved.
 * @license http://www.gnu.org/copyleft/gpl.html GNU/GPL, see LICENSE.php
 * VirtueMart is free software. This version may have been modified pursuant
 * to the GNU General Public License, and as distributed it includes or
 * is derivative of works licensed under the GNU General Public License or
 * other free or open source software licenses.
 * @version $Id: view.html.php 10279 2020-03-03 18:16:05Z Milbo $
 */
// Check to ensure this file is included in Joomla!
defined('_JEXEC') or die('Restricted access');

/**
 * Product details
 *
 * @package VirtueMart
 * @author Max Milbers
 */
class VirtueMartViewProductdetails extends VmView {

    /**
 * Collect all data to show on the template
 *
 * @author Max Milbers
 */
function display($tpl = null) {

$this->show_prices = (int)VmConfig::get('show_prices', 1);

$document = JFactory::getDocument();

$app = JFactory::getApplication();

$menus = $app->getMenu();
$menu = $menus->getActive();

if(!empty($menu->id)){
ShopFunctionsF::setLastVisitedItemId($menu->id);
} else if($itemId = vRequest::getInt('Itemid',false)){
ShopFunctionsF::setLastVisitedItemId($itemId);
}

$pathway = $app->getPathway();
$task = vRequest::getCmd('task');

// Load the product
//$product = $this->get('product'); //Why it is sensefull to use this construction? Imho it makes it just harder
$product_model = VmModel::getModel('product');
$this->assignRef('product_model', $product_model);
$virtuemart_product_idArray = vRequest::getInt('virtuemart_product_id', 0);
if (is_array($virtuemart_product_idArray) and count($virtuemart_product_idArray) > 0) {
$virtuemart_product_id = (int)$virtuemart_product_idArray[0];
} else {
$virtuemart_product_id = (int)$virtuemart_product_idArray;
}

$quantityArray = vRequest::getInt ('quantity', array()); //is sanitized then

$quantity = 1;
if (!empty($quantityArray[0])) {
$quantity = $quantityArray[0];
}

//We need to load the cart here, to get correct discounts
if(!VmConfig::get('use_as_catalog',false)) $cart = VirtuemartCart::getCart();

$ratingModel = VmModel::getModel('ratings');
$product_model->withRating = $this->showRating = $ratingModel->showRating($virtuemart_product_id);
$product = $product_model->getProduct($virtuemart_product_id,TRUE,TRUE,TRUE,$quantity);
$this->assignRef('product', $product);

$last_category_id = shopFunctionsF::getLastVisitedCategoryId();

$customfieldsModel = VmModel::getModel ('Customfields');

if (!empty($product->customfields)){
$customfieldsModel -> displayProductCustomfieldFE ($product, $product->customfields);
}

if (isset($product->access) && $product->access == false) {

$app->enqueueMessage(vmText::_('COM_VIRTUEMART_RESTRICTED_ACCESS'), 'notice');

if (JFactory::getUser()->get('guest')) {
echo shopFunctionsF::getLoginForm(false);
} else {
$app->setHeader('status', 403, true);
}

return;

} else if (empty($product->slug)) {

//Todo this should be redesigned to fit better for SEO
$app->enqueueMessage(vmText::_('COM_VIRTUEMART_PRODUCT_NOT_FOUND'), 'notice');

$categoryLink = '';
if (!$last_category_id) {
$last_category_id = vRequest::getInt('virtuemart_category_id', 0);
}
if ($last_category_id) {
$categoryLink = '&virtuemart_category_id=' . $last_category_id;
}

if (VmConfig::get('handle_404',1)) {
header($_SERVER["SERVER_PROTOCOL"]." 404 Not Found");

$cat = VmModel::getModel('category')->getCategory($last_category_id);
if(empty($cat->virtuemart_category_id)){
$last_category_id = 0;
}
vRequest::setVar('virtuemart_category_id', $last_category_id);

//Todo we could here also get the home menu item and display that one.
$document = JFactory::getDocument();
JLoader::register('VirtueMartControllerCategory',VMPATH_SITE .'/controllers/category.php');
$controller = new VirtuemartControllerCategory();
$view = $controller->getView('category', 'html', '', array('layout' => 'default'));
$view->assignRef('document', $document);
$view->display();

} else {
throw new RuntimeException('VirtueMart product not found.', 404);
}

return;

}

$isCustomVariant = false;
if (!empty($product->customfields)) {
foreach ($product->customfields as $k => $custom) {
if($custom->field_type == 'C' and $custom->virtuemart_product_id != $virtuemart_product_id){
$isCustomVariant = $custom;
}
if (!empty($custom->layout_pos)) {
$product->customfieldsSorted[$custom->layout_pos][] = $custom;
} else {
$product->customfieldsSorted['normal'][] = $custom;
}
unset($product->customfields);
}

}



$product_model->addImages($product);


if (isset($product->min_order_level) && (int) $product->min_order_level > 0) {
$this->min_order_level = $product->min_order_level;
} else {
$this->min_order_level = 1;
}

if (isset($product->step_order_level) && (int) $product->step_order_level > 0) {
$this->step_order_level = $product->step_order_level;
} else {
$this->step_order_level = 1;
}

$currency = CurrencyDisplay::getInstance();
$this->assignRef('currency', $currency);


// Load the neighbours
if (VmConfig::get('product_navigation', 1)) {
$product->neighbours = $product_model->getNeighborProducts($product);
}


if (VmConfig::get('show_manufacturers', 1) && !empty($this->product->virtuemart_manufacturer_id)) {
$manModel = VmModel::getModel('manufacturer');
$mans = array();
// Gebe die Hersteller aus
foreach($this->product->virtuemart_manufacturer_id as $manufacturer_id) {
$manufacturer = $manModel->getManufacturer( $manufacturer_id );
$manModel->addImages($manufacturer, 1);
$mans[]=$manufacturer;
}
$this->product->manufacturers = $mans;
}
// Load the category
$category_model = VmModel::getModel('category');
$seo_full = VmConfig::get('seo_full',true);
if(in_array($last_category_id,$product->categories) && !$seo_full) $product->virtuemart_category_id = $last_category_id;

shopFunctionsF::setLastVisitedCategoryId($product->virtuemart_category_id);


if(!empty($menu) ){
$t = $menu->params->get('cat_productdetails','');
if($t!=''){
$this->cat_productdetails = $t;
}
}
if(!isset($this->cat_productdetails)){
$this->cat_productdetails = VmConfig::get('cat_productdetails',0);
}
//Fallback for BC
VmConfig::set('showCategory', $this->cat_productdetails);

if ($category_model) {

$category = $category_model->getCategory($product->virtuemart_category_id, $this->cat_productdetails);
if($category->parents===null) $category->parents = $category_model->getParentsList($product->virtuemart_category_id);
if(in_array($last_category_id,$product->categories) && !$seo_full) $product->category_name = $category->category_name;

$category_model->addImages($category, 1);
if($this->cat_productdetails){
$category_model->addImages($category->children, 1);
}
$this->assignRef('category', $category);

//Seems we dont need this anylonger, destroyed the breadcrumb
                    if ($category->parents) { foreach ($category->parents as $c) {
if(is_object($c) and !empty($c->category_name) and !empty($c->published)){
$pathway->addItem(strip_tags(vmText::_($c->category_name)), JRoute::_('index.php?option=com_virtuemart&view=category&virtuemart_category_id=' . $c->virtuemart_category_id, FALSE));
} else {
vmdebug('Error, parent category has no name, breadcrumb maybe broken, category',$c);
}
}
}


}

$addPrdNameCrumb = true;

if(!empty($menu->query['view']) and $menu->query['view']=='productdetails' and $menu->title == $product->product_name) {
$addPrdNameCrumb = false;
}
if($addPrdNameCrumb)$pathway->addItem(strip_tags(html_entity_decode($product->product_name,ENT_QUOTES)));

if (!empty($tpl)) {
$format = $tpl;
} else {
$format = vRequest::getCmd('format', 'html');
}
if ($format == 'html') {
// remove joomla canonical before adding it
foreach ( $document->_links as $k => $array ) {
if ( $array['relation'] == 'canonical' ) {
unset($document->_links[$k]);
break;
}
}

// Set Canonic link
$canonical = $product->canonical;
if($isCustomVariant !==false and !empty($isCustomVariant->usecanonical) and !empty($product->product_parent_id)){
$parent = $product_model ->getProduct($product->product_parent_id);
if($parent){
$canonical = $parent->canonical;
}
}
$document->addHeadLink( JUri::getInstance()->toString(array('scheme', 'host', 'port')).JRoute::_($canonical), 'canonical', 'rel', '');


} else if($format == 'pdf'){
defined('K_PATH_IMAGES') or define ('K_PATH_IMAGES', VMPATH_ROOT);
}

// Set the titles
// $document->setTitle should be after the additem pathway
if ($product->customtitle) {
$document->setTitle(strip_tags(html_entity_decode($product->customtitle,ENT_QUOTES)));
} else {
$catName = '';
if($category->published and !empty($category->category_name)){
$catName = $category->category_name.': ';
}
$document->setTitle(strip_tags(html_entity_decode($catName . $product->product_name,ENT_QUOTES)));
}

$this->allowReview = $ratingModel->allowReview($product->virtuemart_product_id);
$this->showReview = $ratingModel->showReview($product->virtuemart_product_id);
$this->rating_reviews='';
if ($this->showReview) {
$this->review = $ratingModel->getProductReviewForUser($product->virtuemart_product_id);
$this->showall = vRequest::getBool( 'showall', FALSE );
if($this->showall){
$limit = 50;
} else {
$limit = VmConfig::get( 'vm_num_ratings_show', 3 );
}

$this->rating_reviews = $ratingModel->getReviews($product->virtuemart_product_id, 0, $limit);
}

if ($this->showRating) {
$this->vote = $ratingModel->getVoteByProduct($product->virtuemart_product_id);
}

$this->allowRating = $ratingModel->allowRating($product->virtuemart_product_id);

$superVendor = vmAccess::isSuperVendor();


if($superVendor == 1 or (vmAccess::manager('product') and $superVendor==$product->virtuemart_vendor_id)){
$edit_link = JURI::root() . 'index.php?option=com_virtuemart&tmpl=component&manage=1&view=product&task=edit&virtuemart_product_id=' . $product->virtuemart_product_id;
$this->edit_link = $this->linkIcon($edit_link, 'COM_VIRTUEMART_PRODUCT_FORM_EDIT_PRODUCT', 'edit', false, false);
} else {
$this->edit_link = "";
}

// Load the user details
$this->user = JFactory::getUser();

// More reviews link
//vRequest::setVar('showall', 1);
$this->more_reviews = JRoute::_(vmURI::getCurrentUrlBy('get').'&showall=1');

if ($product->metadesc) {
$document->setDescription( strip_tags(html_entity_decode($product->metadesc,ENT_QUOTES)) );
} else {
$document->setDescription( strip_tags(html_entity_decode($product->product_name,ENT_QUOTES)) . " " . $category->category_name . " " . strip_tags(html_entity_decode($product->product_s_desc,ENT_QUOTES)) );
}

if ($product->metakey) {
$document->setMetaData('keywords', $product->metakey);
}

if ($product->metarobot) {
$document->setMetaData('robots', $product->metarobot);
}

if ($app->getCfg('MetaTitle') == '1') {
$document->setMetaData('title', $product->product_name);  //Maybe better product_name
}
if ($app->getCfg('MetaAuthor') == '1') {
$document->setMetaData('author', $product->metaauthor);
}

$showBasePrice = (vmAccess::manager() or vmAccess::isSuperVendor());
$this->assignRef('showBasePrice', $showBasePrice);

$product->event = new stdClass();
$product->event->afterDisplayTitle = '';
$product->event->beforeDisplayContent = '';
$product->event->afterDisplayContent = '';
if (VmConfig::get('enable_content_plugin', 0)) {
shopFunctionsF::triggerContentPlugin($product, 'productdetails','product_desc');
}

$this->productDisplayShipments = array();
$this->productDisplayPayments = array();

VmConfig::importVMPlugins('vmpayment');
$dispatcher = JDispatcher::getInstance();

$productC = clone($product);
$d = VmConfig::$_debug;
if(VmConfig::get('debug_enable_methods',false)){
VmConfig::$_debug = 1;
}
//@Todo lets use only one trigger
$returnValues = $dispatcher->trigger('plgVmOnProductDisplayShipment', array($productC, &$this->productDisplayShipments));
$returnValues = $dispatcher->trigger('plgVmOnProductDisplayPayment', array($productC, &$this->productDisplayPayments));

$this->productDisplayTypes = array();
$productDisplayTypes = array();
if(!empty($this->productDisplayShipments)) $productDisplayTypes[] = 'productDisplayShipments';
if(!empty($this->productDisplayPayments)) $productDisplayTypes[] = 'productDisplayPayments';

foreach ($productDisplayTypes as $productDisplayType) {

if(empty($this->{$productDisplayType})){
continue;
} else if (!is_array($this->{$productDisplayType})){
$this->{$productDisplayType} = array($this->{$productDisplayType});
}

foreach( $this->{$productDisplayType} as $k=>$productDisplay ) {

if(empty($productDisplay)){
continue;
} else if(!is_array($productDisplay)){
$productDisplay = array($productDisplay);
}

foreach( $productDisplay as $virtuemart_method_id => $productDisplayHtml ) {
if(!empty($productDisplayHtml)){
if(empty($this->productDisplayTypes[$productDisplayType])){
$this->productDisplayTypes[$productDisplayType] = array();
}
if(empty($this->productDisplayTypes[$productDisplayType][$k])){
$this->productDisplayTypes[$productDisplayType][$k] = array();
}
$this->productDisplayTypes[$productDisplayType][$k][$virtuemart_method_id] = $productDisplayHtml;
}
}
}
}
VmConfig::$_debug = $d;

if (empty($category->category_template)) {
$category->category_template = VmConfig::get('categorytemplate');
}

if(vRequest::getCmd( 'layout', 'default' )=='notify') $this->setLayout('notify'); //Added by Seyi Awofadeju to catch notify layout

$layout = $this->getLayout();
if($layout === 'default'){
$layout = '';
}
if ( ($layout === 'default' || empty($layout)) and !empty($product->layout) ) {
$layout = $product->layout;
}
VmTemplate::setVmTemplate($this, $category->category_template, 0, $category->category_product_layout, $layout);

VirtueMartModelProduct::addProductToRecent($virtuemart_product_id);

vmLanguage::loadJLang('com_virtuemart');

vmJsApi::chosenDropDowns();

//This must be loaded after the customfields are rendered (they may need to overwrite the handlers)
if (VmConfig::get ('jdynupdate', TRUE) or !VmConfig::isSite()) {
vmJsApi::jDynUpdate();
}

vmJsApi::jPrice();

parent::display($tpl);
    }

function renderMailLayout ($doVendor, $recipient) {
$tpl = VmConfig::get('order_mail_html') ? 'mail_html_notify' : 'mail_raw_notify';

$this->doVendor=$doVendor;
$this->fromPdf=false;
$this->uselayout = $tpl;
$this->subject = !empty($this->subject) ? $this->subject : vmText::_('COM_VIRTUEMART_CART_NOTIFY_MAIL_SUBJECT');
$this->layoutName = $tpl;
$this->setLayout($tpl);
$this->isMail = true;
$this->user=new stdClass();
$this->user->name=$this->vendor->vendor_store_name;
$this->user->email=$this->vendorEmail;
parent::display();
}
    public function showLastCategory($tpl) {
$this->prepareContinueLink();
parent::display ($tpl);
    }


}

// pure php no closing tag




I don't know why i does'nt work with new release file.

Thank you all for your help.

regards.

[amlil71]

To explain how i have solved the problem i have replaced this code

Code Select Expand

if ($category->parents and !empty($menu->query['view']) and $menu->query['view']!='productdetails') {
foreach ($category->parents as $c) {
by this one

Code Select Expand

if ($category->parents) {foreach ($category->parents as $c) {

Regards

[pinochico]

To explain how i have solved the problem i have replaced this code

Code Select Expand

if ($category->parents and !empty($menu->query['view']) and $menu->query['view']!='productdetails') {
foreach ($category->parents as $c) {
by this one

Code Select Expand

if ($category->parents) {foreach ($category->parents as $c) {

Regards

Yep, is not ready for others.
If you have menu item for product detail, then breadcrumbs will be wrong.

[Studio 42]

Merci pour ta réponse.

J'ai du mal à comprendre aussi car j'utilise aussi SH404SEF pour un autre site mais je n'ai pas de souci avec l'affichage du breadcrumb.

Je vais installer le site en local et faire des tests car les tests réalisés en production me cassent le SEO.

Thank you all for your help. I will install the website in local and try to debug the problem.

have a nice day.

Regards.

Please, Verfiy virtuemart configuration > Seo settings : Use full category tree for product links