VirtueMart Forum

VirtueMart 2 + 3 + 4 => Virtuemart Development and bug reports => Topic started by: greg@cat6.co.za on June 09, 2013, 18:08:21 PM

Title: Private class member to protected
Post by: greg@cat6.co.za on June 09, 2013, 18:08:21 PM
Hi

Could you look to changing class member scope from private to protected?

I purchased the istraxx_quantity plugin, but it is not what I want, so I have overloaded VirtueMartModelProduct, calculationHelper etc by accessing there instance variables, and implemented quantity based pricing tables.

You already have 90% of the functionality implemented, so I don't want to hack it. The problem is that methods and variables have been declared as private,
so I have had to change these declarations to allow derived classes to access them.

(A "nice to have" would be if you could insert triggers into functions like VmModel::getModel() and calculationHelper::getInstance() so that plugins can seamelessly overload classes.)

Thanks
Greg
Title: Re: Private class member to protected
Post by: Milbo on June 09, 2013, 23:50:31 PM
Which ones? and what is missing? I am interested what you wanna write.