0 - Cannot access property started with '\0' while accessing product page

[Milbo]

But we could extend and write

Code Select Expand

if (empty($k) or strpos($k, "\0")===0) continue;

I just need to know if this construction removes the bug in php7. Your explanation support my idea :-) I like it more than the other. Jumbos idea has the disadvantage, that you cannot inherit values to children, which do not exist for the parent.

[Jumbo!]

You can not inherit private and protected properties of parent products to children using get_object_vars() in any PHP version.

strpos($k, "\0")===0 check looks bit odd and hard coded to me.

It is better to ensure that we are inheriting to the public properties of the parent.

Code Select Expand

if(!property_exists($parentProduct, $k)) continue;

Here is a function which ensure correct conversions of object to array if you need to inherit every properties of the object.

Code Select Expand

function object_to_array($object)
{
$reflectionClass = new ReflectionClass(get_class($object));
$array = array();

foreach ($reflectionClass->getProperties() as $property)
{
$property->setAccessible(true);
$array[$property->getName()] = $property->getValue($object);
$property->setAccessible(false);
}

return $array;
}

But this is probably little too much considering the requirement we have here.

[Milbo]

You can not inherit private and protected properties of parent products to children using get_object_vars() in any PHP version.

It is anyway not intended. The version below php7 handles it different. There was no problem before.

strpos($k, "\0")===0 check looks bit odd and hard coded to me.

Imho the way you suggest yourself a time ago and I think I used it, because I found it on some php official page.

It is better to ensure that we are inheriting to the public properties of the parent.

Code Select Expand

if(!property_exists($parentProduct, $k)) continue;

Here is a function which ensure correct conversions of object to array if you need to inherit every properties of the object.

Code Select Expand

function object_to_array($object)
{
$reflectionClass = new ReflectionClass(get_class($object));
$array = array();

foreach ($reflectionClass->getProperties() as $property)
{
$property->setAccessible(true);
$array[$property->getName()] = $property->getValue($object);
$property->setAccessible(false);
}

return $array;
}

But this is probably little too much considering the requirement we have here.

Maybe not bad as general function, but I wonder about the $property->setAccessible(true); I would do a check if it is accessible, or?

[Milbo]

You can not inherit private and protected properties of parent products to children using get_object_vars() in any PHP version.

strpos($k, "\0")===0 check looks bit odd and hard coded to me.

It is better to ensure that we are inheriting to the public properties of the parent.

Code Select Expand

if(!property_exists($parentProduct, $k)) continue;

Code Select Expand


foreach ($attribs as $k=> $v) {
if (!property_exists($parentProduct, $k)) continue;
if ('product_in_stock' != $k and 'product_ordered' != $k) {// Do not copy parent stock into child
if (strpos ($k, '_') !== 0 and empty($child->$k)) {
$child->$k = $v;
// vmdebug($child->product_parent_id.' $child->$k',$child->$k);
}
}
}