Author Topic: [BUG] [SOLVED] Terms of Service field not validated at all  (Read 19630 times)

GJC Web Design

  • 3rd party VirtueMart Developer
  • Super Hero
  • *
  • Posts: 10638
  • Virtuemart, Joomla & php developer
    • GJC Web Design
  • VirtueMart Version: 3.8.8
Re: [BUG] [SOLVED] Terms of Service field not validated at all
« Reply #15 on: October 03, 2014, 23:16:14 pm »
Is it not easier just to write a javascript snippet that disables the checkout button if the box isn't checked?

the above code really seems a sledgehammer to crack a nut
GJC Web Design
VirtueMart and Joomla Developers - php developers https://www.gjcwebdesign.com
VM3 AusPost Shipping Plugin - e-go Shipping Plugin - VM3 Postcode Shipping Plugin - Radius Shipping Plugin - VM3 NZ Post Shipping Plugin - AusPost Estimator
Samport Payment Plugin - EcomMerchant Payment Plugin - ccBill payment Plugin
VM2 Product Lock Extension - VM2 Preconfig Adresses Extension - TaxCloud USA Taxes Plugin - Virtuemart  Product Review Component
https://extensions.joomla.org/profile/profile/details/67210
Contact for any VirtueMart or Joomla development & customisation

bluezeyes

  • Jr. Member
  • **
  • Posts: 80
  • VirtueMart Version: 3.0.3
Re: [BUG] [SOLVED] Terms of Service field not validated at all
« Reply #16 on: October 06, 2014, 01:40:22 am »
IMHO better to fix the cause of an erroneous behaviour then to try to fix the result of it with javascript, which could break / not been enabled / blocked etc.

Better the VM is working stable on a low level but working then to handover Bugfix-functions on client-side to fix it.

Greets

Milbo

  • Virtuemart Projectleader
  • Administrator
  • Super Hero
  • *
  • Posts: 10495
  • VM4.0.7 Eagle Owl
    • VM3 Extensions
  • VirtueMart Version: VirtueMart 3 on joomla 3
Re: [BUG] [SOLVED] Terms of Service field not validated at all
« Reply #17 on: October 06, 2014, 10:46:04 am »
The solution is to use VM3 guys.

If we keep all the time to enhance vm2, we can do that for 100s of years. But it implies also that there are constantly changes in the behaviour, which a lot people just notice at bugs (why is my stuff not anylonger working). That is the reason we have major releases in software development.

When I fix bugs again, which I already redesigned in vm3, then there are not enough ressources to write VM3. Furthermore vm2 would become more and more VM3. This is doubled work.

So long there is no problem if you are a bit flexible. If people dont want to use the TOS, then they can set agreed as hidden field on with default =1 and thats it. It is atm mainly a matter of handling and not that something does not work.
Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

Shazam0527

  • Beginner
  • *
  • Posts: 9
Re: [BUG] [SOLVED] Terms of Service field not validated at all
« Reply #18 on: October 06, 2014, 19:46:44 pm »
I'd be willing to use VM3, but I can't even find the download for it on the main website..

paradise4

  • Beginner
  • *
  • Posts: 26
Re: [BUG] [SOLVED] Terms of Service field not validated at all
« Reply #19 on: October 08, 2014, 11:07:44 am »
Hi,

I'm using VM 2.6.10 and applied the fix for the "agree-to-tos-bug". Now customers can't register anymore because on saving the bill-to-data, vm redirects to the cart, shows the "you have to agree to the tos"-messager and the data isn't saved.

Any help available on that issue?

Thanks in advance!

paradise4

  • Beginner
  • *
  • Posts: 26
Re: [BUG] [SOLVED] Terms of Service field not validated at all
« Reply #20 on: October 21, 2014, 10:39:02 am »
So you recommend to use the non-stable version 2.9.9 because the stable version contains bugs (like this one, which is a real show-stopper for shops in Germany)??? Come on, you can't be serious!

GJC Web Design

  • 3rd party VirtueMart Developer
  • Super Hero
  • *
  • Posts: 10638
  • Virtuemart, Joomla & php developer
    • GJC Web Design
  • VirtueMart Version: 3.8.8
Re: [BUG] [SOLVED] Terms of Service field not validated at all
« Reply #21 on: October 21, 2014, 10:43:56 am »
I say again->  Is it not easier just to write a javascript snippet that disables the checkout button if the box isn't checked?

that's what I use on VM2.0 if T&C's are required
GJC Web Design
VirtueMart and Joomla Developers - php developers https://www.gjcwebdesign.com
VM3 AusPost Shipping Plugin - e-go Shipping Plugin - VM3 Postcode Shipping Plugin - Radius Shipping Plugin - VM3 NZ Post Shipping Plugin - AusPost Estimator
Samport Payment Plugin - EcomMerchant Payment Plugin - ccBill payment Plugin
VM2 Product Lock Extension - VM2 Preconfig Adresses Extension - TaxCloud USA Taxes Plugin - Virtuemart  Product Review Component
https://extensions.joomla.org/profile/profile/details/67210
Contact for any VirtueMart or Joomla development & customisation

paradise4

  • Beginner
  • *
  • Posts: 26
Re: [BUG] [SOLVED] Terms of Service field not validated at all
« Reply #22 on: October 22, 2014, 10:42:30 am »
Hi GJC,

I think it would be better to fix the bug, but if you can provide the mentioned snippet, I'd be happy with it :)

GJC Web Design

  • 3rd party VirtueMart Developer
  • Super Hero
  • *
  • Posts: 10638
  • Virtuemart, Joomla & php developer
    • GJC Web Design
  • VirtueMart Version: 3.8.8
Re: [BUG] [SOLVED] Terms of Service field not validated at all
« Reply #23 on: October 22, 2014, 10:48:31 am »
As discussed elsewhere - if the devs keep rebuilding VM2 it becomes VM3 - VM3 is days away..


http://bit.ly/1x7SSAn

GJC Web Design
VirtueMart and Joomla Developers - php developers https://www.gjcwebdesign.com
VM3 AusPost Shipping Plugin - e-go Shipping Plugin - VM3 Postcode Shipping Plugin - Radius Shipping Plugin - VM3 NZ Post Shipping Plugin - AusPost Estimator
Samport Payment Plugin - EcomMerchant Payment Plugin - ccBill payment Plugin
VM2 Product Lock Extension - VM2 Preconfig Adresses Extension - TaxCloud USA Taxes Plugin - Virtuemart  Product Review Component
https://extensions.joomla.org/profile/profile/details/67210
Contact for any VirtueMart or Joomla development & customisation

dinoide

  • Beginner
  • *
  • Posts: 23
Re: [BUG] [SOLVED] Terms of Service field not validated at all
« Reply #24 on: October 31, 2014, 09:04:56 am »
same problem with 2.9.9.2

nothing TOS in the buying process. (i have activated of course)

paradise4

  • Beginner
  • *
  • Posts: 26
Re: [BUG] [SOLVED] Terms of Service field not validated at all
« Reply #25 on: November 13, 2014, 13:49:20 pm »
So "VM 3 is days away" (on: October 22, 2014, 10:48:31 am )?  ;D Rather weeks or months, at least for a stable version where the TOS checkbox is actually being validated, I'm afraid...

jenkinhill

  • UK Web Developer & Consultant
  • Global Moderator
  • Super Hero
  • *
  • Posts: 28396
  • Always on vacation
    • Jenkin Hill Internet
Re: [BUG] [SOLVED] Terms of Service field not validated at all
« Reply #26 on: November 13, 2014, 15:23:37 pm »
Rather weeks or months, at least for a stable version where the TOS checkbox is actually being validated, I'm afraid...

So have you been helping to speed the process by contributing a little time to testing the RC versions and reporting any bugs you find in the development forum?  http://forum.virtuemart.net/index.php?board=136.0
Kelvyn

Jenkin Hill Internet,
Lowestoft, Suffolk, UK

Unsolicited PMs/emails will be ignored.

Please mention your VirtueMart, Joomla and PHP versions when asking a question in this forum

Currently using VirtueMart 4.0.8 10748  J3.10.11 PHP 7.4.30

paradise4

  • Beginner
  • *
  • Posts: 26
Re: [BUG] [SOLVED] Terms of Service field not validated at all
« Reply #27 on: November 14, 2014, 10:53:12 am »
I'd love to, but at the moment I'm spending a lot of time trying to solve the TOS bug in a proper way (JS isn't as it can be blocked).
By the way, why is the bug marked as [SOLVED] when it isn't?

AH

  • Global Moderator
  • Sr. Member
  • *
  • Posts: 3510
  • VirtueMart Version: 3.8.9
Re: [BUG] [SOLVED] Terms of Service field not validated at all
« Reply #28 on: November 14, 2014, 20:12:18 pm »
If people are blocking javascript then it is pretty pointless visiting modern e-commerce sites!
Regards
A

Joomla 3.9.27
php 7.4

T.A. Garrison, LLC

  • Jr. Member
  • **
  • Posts: 54
  • Thomas Garrison
    • T.A. Garrison, LLC
Re: [BUG] [SOLVED] Terms of Service field not validated at all
« Reply #29 on: January 22, 2015, 20:41:15 pm »
I have to add my 2 cents...
I agree that this issues is NOT resolved.
I don't have either of the boxes checked:
Must agree to Terms of Service on EVERY ORDER    
Show Terms of Service on the cart/checkout

Yet, no matter what I do, users are forced to check the box on the front end in order to continue with the checkout.
It's frustrating for "older" customers who frequent my client's site.

This project is Joomla 3.3.6 and VM 3.0.3

I don't want to hack anything or override something that is already part of what's available in admin to control.

Thoughts?

Update:
I actually followed what I'd done in the previous version - followed jenkinhill's process - http://forum.virtuemart.net/index.php?topic=111063.msg372666#msg372666
That same process works in VM3. No I don't have the box and customers are not mandated to check the box.
T.A. Garrison, LLC
3150 Orleans St. # 28261
Bellingham, WA 98228