Bug in VirtueMartModelState getStateByCode (Rev 5074)

[Stephen Roberts]

I believe there's a bug in the state model's getStateByCode() function. The $code variable is being treated as an int in the query:

Code Select Expand

$query = 'SELECT * FROM `#__virtuemart_states` WHERE `' . $stateCodeFieldname . '` = ' (int)$code;

If I understand the function properly, the code should be treated as a 2 or 3 character string.

[Milbo]

Interesting,. on the other side, this code is never called. So I just deleted it. I think it was done while we add the security stuff in the summer. Thx

[Stephen Roberts]

Gotcha. It was almost identical to getStateIDByName() in shopfunctions.