Serious bug when using currency converter

[Crowman8]

 

Hi i found this

The next problem is also very serious.
VM is "converting" the shipping costs again AFTER the order is confirmed. This affects the amount of shipping in the order totals, either increasing or decreasing the amount a second time by the conversion ratio. All looks OK on the confirm page, but once the order is placed, the shipping amount is wrong, and this also affects the amount passed to any payment processor as this adjusted shipping rate is also passed to the payment module.

We are using the Standard Shipping Module - if you are using a different shipping module test to ensure our suggested fix works for your configuration.

Here is our fix:

In line 1598 of the file "administrator/components/com_virtuemart/classes/ps_checkout.php", comment out the below lines:
Code:
$d['shipping_tax'] = $GLOBALS['CURRENCY']->convert( $d['shipping_tax'] );
$d['shipping_total'] = $GLOBALS['CURRENCY']->convert( $d['shipping_total']);


In line 1598 of the file administrator/components/com_virtuemart/classes/ps_checkout.php


i fount only this  :

     }

What means comment out the below lines:

Code:
$d['shipping_tax'] = $GLOBALS['CURRENCY']->convert( $d['shipping_tax'] );
$d['shipping_total'] = $GLOBALS['CURRENCY']->convert( $d['shipping_total']);


must i insert this lines on line 1598 ?

Thanks for a answer

Reagrd Chris

[Scar]

Comment out means to make the server not take these lines into consideration. You do it by putting /* codelines here */

/*
$d['shipping_tax'] = $GLOBALS['CURRENCY']->convert( $d['shipping_tax'] );
$d['shipping_total'] = $GLOBALS['CURRENCY']->convert( $d['shipping_total']);
*/

If you don't find the lines exactly at 1598 just search for them, they are probably nearby.

[supplierman]

Any templates use between it thatswhy the line number is showing wrong, dont worry just, but your code is right

[Crowman8]

thanks now it works fine