Bug in shopfunctionsF ?

[Jose M.]

Hi,
I'm sorry if I'm wrong, but line 520 of the file shopfunctionsf.php I think it should be

Code Select Expand

if(isset($view->doVendor) && $noVendorMail) {

instead of

Code Select Expand

if(isset($view->doVendor) && !$noVendorMail) {

That is, that $noVendorMail is TRUE


Thanks
Jose

[Milbo]

Which version? because it seems it is now already as you suggest.

[Jose M.]

Hi Milbo!

I have reviewed 3.2.3.9587, 3.2.2 and 3.21

Greetings!

Jose M.

[Milbo]

Take a look here

http://dev.virtuemart.net/projects/virtuemart/repository/diff/branches/com_virtuemart.3.0.12.4/components/com_virtuemart/helpers/shopfunctionsf.php?utf8=%E2%9C%93&rev=9402&rev_to=9400

It was set correctly, from begin on.

[Jose M.]

Hi Milbo,
Is this a feature to send an email to the seller?
Then it only does when $noVendorMail is FALSE and I think it should be when $noVendorMail is TRUE.

I had the problem that when I sent an email to buyers who had indicated "notify me", for each mail to a buyer, he received an email as a seller.
That is, if you send ten emails to ten buyers, the seller also receives ten emails.

Changing

Code Select Expand

!$noVendorMail for

Code Select Expand

$noVendorMail in line 520, it only sends mail to buyers.

Sorry, I'm a bit confused.
Thanks
Jose

[Milbo]

I was also confused. I read your post exactly the opposite, lol. I read
the code is .... it should be....
But you wrote,.. the code should be that ... instead of this.

But you describe the correct behaviour. This function should send an email to the vendor if "doVendor" is set. For old legacy reasons, we have to use the isset. Of course it should be just one boolean, that would be easier. As you can see the code has a comment

Code Select Expand


//TODO this is quirk, why it is using here $noVendorMail, but everywhere else it is using $doVendor => this make logic trouble

The code was written by a lot people. But back to the problem.

Code Select Expand


if(isset($view->doVendor) && !$noVendorMail) {

The standard is $noVendorMail=false, this means, when a doVendor is set, then it sends the vendor email.

[Jose M.]

Hello,
I am sorry, I do not speak English and I can not explain it well.

The question is that now, send mail when $noVendorMail is FALSE or not set.

Thanks
Regards

Jose

[Milbo]

Code Select Expand


if(isset($view->doVendor) && !$noVendorMail) {


It should send the vendor email for

doVendor = true and $noVendorMail=false

[Jose M.]

Thanks!

Jose