News:

Support the VirtueMart project and become a member

Main Menu

Limits

Started by fmp.martins, March 02, 2012, 16:56:43 PM

Previous topic - Next topic

fmp.martins

The funtion getLimitBox in administrator\components\com_virtuemart\helpers\vmmodel.php does not have the 'all' ready for i18n.
The correct 'all' would be $limits[] = JHTML::_('select.option', '0', JText::_('JALL'));

I've also found it buggy...
For instance, I have a menu entry that lists all my products (index.php?option=com_virtuemart&view=category&virtuemart_category_id=0), and the limit box says "ALL", but it is not showing all the products, since I have the previous/next listing options with several pages and when one navigates through the list, it has a wierd behaviour, it jumps to the category listing and starts showing the top 10 and the lastest products at the bottom...


Edit: the problem exists in the stable 2.0.0, and it seems only partially solved in 2.0.1H (the ALL option has been removed).

lipes

is this problem solved in 2.0.6?

I removed the //     
from the administrator\components\com_virtuemart\helpers\vmmodel.php

in line 643
// $limits[] = JHTML::_('select.option', '0', JText::_('COM_VIRTUEMART_ALL'));
and in line
// $limits[] = JHTML::_('select.option',JRoute::_( $link.'&limit=0'), JText::_('all'));

but in my test webiste it show an big url :S
"/mp5/index.php?option=com_virtuemart&view=category&virtuemart_category_id=2&Itemid=&limit=0&view=category&virtuemart_category_id=2&Itemid=&limit=0"
and the word "all" its there too... dont know why
VM V. online: J2.5.14 | VM 2.0.20a | SQL 5.1.70 | PHP 5.3.25

Milbo

We removed the all option, because it is a completly nonsense option. Try to list 2000 products, your browser wont display it. Before we had an internal block, to load not more than 700 products. At the end it is more confusing, because so you dont know that you do not see all, what is when you have 750 products? You can rise the amount in the vm config and write your own pagination steps.
Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

lipes

VM V. online: J2.5.14 | VM 2.0.20a | SQL 5.1.70 | PHP 5.3.25