Missing $encoding argument in htmlentities() inside default_addtocart.php

Started by konstantin-shkodskih, December 19, 2012, 07:19:00 AM

Previous topic - Next topic

konstantin-shkodskih

Version: 2.0.15f
File: \components\com_virtuemart\views\productdetails\tmpl\default_addtocart.php
String number: 100
Code: <input type="hidden" class="pname" value="<?php echo htmlentities($this->product->product_name) ?>"/>
Notice: missing $encoding argument in function htmlentities(). For this reason, the name of the product in a language other than English (eg Russian) is not properly displayed.

Milbo

This is already in the latest version F, I just added that 2 days ago
Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

konstantin-shkodskih

Thanks! I see that added to version 2.0.16b:
Quotehtmlentities(..., ENT_QUOTES, 'utf-8')
- i meant $encoding parameter.

bytelord

Production: Joomla 2.5.8 | VM 2.0.14 | PHP 5.3.13
Testing     : Joomla 2.5.8 | VM 2.0.16 | PHP 5.3.8
Testing     : Joomla 2.5.8 |    VM 2.1   | PHP 5.3.8

- Don't Forget to mark thread as solved when it is solved!
- Please do not PM with support questions, use the forum!

Milbo

Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

bytelord

lol :) i have too many days to login that i missed some things :)
Production: Joomla 2.5.8 | VM 2.0.14 | PHP 5.3.13
Testing     : Joomla 2.5.8 | VM 2.0.16 | PHP 5.3.8
Testing     : Joomla 2.5.8 |    VM 2.1   | PHP 5.3.8

- Don't Forget to mark thread as solved when it is solved!
- Please do not PM with support questions, use the forum!