list of products per manufacturer, the limit does not work. fix included.

Started by AndyGaskell, February 18, 2013, 21:17:43 PM

Previous topic - Next topic

AndyGaskell

Hi

I noticed a bug in the list of products per manufacture, it was not using the value in "Configuration" -> "Shopfront" -> "Default items per listing view".  It is not using the value there, but is instead defaulting to 10.

This can, I think, be fixed by one line in com_virtuemart/router.php line #335 could be changed from...

$vars['limit'] = vmrouterHelper::$limit;

...to...

$vars['limit'] = VmConfig::get('list_limit', 20);

...I've tested this here, and it works for me, however there are probably some other use cases that'd need testing.

The route for this is, for example...
index.php?option=com_virtuemart&view=category&virtuemart_manufacturer_id=2

Versions:
Joomla!: 2.5.8
php: same on 5.3.10 and 5.3.2
VirtueMart: 2.0.18a

Hope this is helpful, let me know if any more info is needed.

Thanks

Andy
Software Systems: Open For Business
Aberdeen's Leading Open Source Web Systems Provider

Milbo

Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

AndyGaskell

Thanks Milbo

Maybe see you at J & Beyond, really enjoyed your seminar at Joomla Day UK 2011
Software Systems: Open For Business
Aberdeen's Leading Open Source Web Systems Provider