VirtueMart Forum

VirtueMart 2 + 3 + 4 => Virtuemart Development and bug reports => Topic started by: fmp.martins on March 02, 2012, 16:56:43 PM

Title: Limits
Post by: fmp.martins on March 02, 2012, 16:56:43 PM
The funtion getLimitBox in administrator\components\com_virtuemart\helpers\vmmodel.php does not have the 'all' ready for i18n.
The correct 'all' would be $limits[] = JHTML::_('select.option', '0', JText::_('JALL'));

I've also found it buggy...
For instance, I have a menu entry that lists all my products (index.php?option=com_virtuemart&view=category&virtuemart_category_id=0), and the limit box says "ALL", but it is not showing all the products, since I have the previous/next listing options with several pages and when one navigates through the list, it has a wierd behaviour, it jumps to the category listing and starts showing the top 10 and the lastest products at the bottom...


Edit: the problem exists in the stable 2.0.0, and it seems only partially solved in 2.0.1H (the ALL option has been removed).
Title: Re: Limits
Post by: lipes on April 19, 2012, 00:59:02 AM
is this problem solved in 2.0.6?

I removed the //     
from the administrator\components\com_virtuemart\helpers\vmmodel.php

in line 643
// $limits[] = JHTML::_('select.option', '0', JText::_('COM_VIRTUEMART_ALL'));
and in line
// $limits[] = JHTML::_('select.option',JRoute::_( $link.'&limit=0'), JText::_('all'));

but in my test webiste it show an big url :S
"/mp5/index.php?option=com_virtuemart&view=category&virtuemart_category_id=2&Itemid=&limit=0&view=category&virtuemart_category_id=2&Itemid=&limit=0"
and the word "all" its there too... dont know why
Title: Re: Limits
Post by: Milbo on April 22, 2012, 20:36:28 PM
We removed the all option, because it is a completly nonsense option. Try to list 2000 products, your browser wont display it. Before we had an internal block, to load not more than 700 products. At the end it is more confusing, because so you dont know that you do not see all, what is when you have 750 products? You can rise the amount in the vm config and write your own pagination steps.
Title: Re: Limits
Post by: lipes on April 22, 2012, 21:22:51 PM
Correct! :)