VirtueMart Forum

VirtueMart Dev/Coding Central: VM1 (old version) => Quality & Testing VirtueMart 1.1.x => Virtuemart 1.1 Development (Archiv) => Q&T Resolved => Topic started by: doorknob on March 28, 2009, 19:52:08 PM

Title: short php tags problem
Post by: doorknob on March 28, 2009, 19:52:08 PM
administrator\components\com_virtuemart\classes\payment\ps_cashondel.php contains a couple of '<?=' short php tags (lines 42 & 42). These tags are only accepted if specifically permitted in the php.ini file and so will cause errors at some sites. These should be replaced with '<?php echo' to make them reliable.

Regards
Phil
Title: Re: short php tags problem
Post by: doorknob on March 30, 2009, 16:45:24 PM
I just did a search for '<? ' and found loads of examples in the vm code. No other component had even a single example! This could the cause of any number of reported problems that you were unable to replicate. You guys should configure your php.ini files with 'short_open_tags=off' to expose these problems in testing.

Regards
Phil
Title: Re: short php tags problem
Post by: aravot on March 30, 2009, 18:12:10 PM
Thanks, I am on it.
Title: Re: short php tags problem
Post by: aravot on May 11, 2009, 21:36:31 PM
Fixed for 1.1.4