VirtueMart Forum

VirtueMart Dev/Coding Central: VM1 (old version) => Quality & Testing VirtueMart 1.1.x => Virtuemart 1.1 Development (Archiv) => Q&T Resolved => Topic started by: iamalive on March 05, 2008, 21:29:25 PM

Title: [FIXED] Bug Report "No Image" link is wrong
Post by: iamalive on March 05, 2008, 21:29:25 PM
Hi Just loaded up
VirtueMart 1.1 revision 1296

and when clicking the "no image" image I get the following Message
Quote
Not Found

The requested URL/product/http://mysite.ch/components/com_virtuemart/themes/default/images/noimage.gif was not found on this server.

Additionally, a 404 Not Found error was encountered while trying to use an ErrorDocument to handle the request.

It seems to be genarting an additional "/product/ before the URL.

Regards

David
Title: Re: [CONFIRMED] Bug Report "No Image" link is wrong
Post by: aravot on March 07, 2008, 07:52:23 AM
Tracker URL -> http://dev.virtuemart.net/cb/issue/1882
Title: Re: [TRACKER 1882] Bug Report "No Image" link is wrong
Post by: gregdev on March 07, 2008, 08:31:01 AM
What page does this happen on? I can't reproduce it.

Greg
Title: Re: [TRACKER 1882] Bug Report "No Image" link is wrong
Post by: iamalive on March 07, 2008, 16:52:01 PM
Hi

This is one page:

http://joomla.neukom-electronic.ch/index.php?option=com_virtuemart&page=shop.browse&category_id=15&Itemid=15 (http://joomla.neukom-electronic.ch/index.php?option=com_virtuemart&page=shop.browse&category_id=15&Itemid=15)

It's Joomla 1.5.1

Regards
Title: Re: [TRACKER 1882] Bug Report "No Image" link is wrong
Post by: mauri on March 07, 2008, 20:45:08 PM
Quote from: iamalive on March 07, 2008, 16:52:01 PM
Hi

This is one page:

http://joomla.neukom-electronic.ch/index.php?option=com_virtuemart&page=shop.browse&category_id=15&Itemid=15 (http://joomla.neukom-electronic.ch/index.php?option=com_virtuemart&page=shop.browse&category_id=15&Itemid=15)

It's Joomla 1.5.1

Regards
Its browse_1 file.
<?php echo $image_url ?>product/<?php echo $product_full_image ?>

In shop_browse no_image gets new url:
$product_full_image = VM_THEMEURL.'images/'.NO_IMAGE;
Title: Re: [TRACKER 1882] Bug Report "No Image" link is wrong
Post by: iamalive on March 07, 2008, 23:01:36 PM
Thanks Mauri, but I'm not quite sure what you mean.

I tried replacing
Quote$product_full_image
with
QuoteVM_THEMEURL.'images/'.NO_IMAGE;

It solves the problem, by not showing any image, not even where I do have images. Not quite my plan.

I noticed that the link generated when clicking the image contained the main URL twice:

Quotehttp://joomla.neukom-electronic.ch/product/http://joomla.neukom-electronic.ch/components/com_virtuemart/themes/default/images/noimage.gif (http://joomla.neukom-electronic.ch/product/http://joomla.neukom-electronic.ch/components/com_virtuemart/themes/default/images/noimage.gif)

so there's something too!

I hope you guys can help further.

Regards
Title: Re: [TRACKER 1882] Bug Report "No Image" link is wrong
Post by: mauri on March 08, 2008, 11:35:49 AM
Hi iamalive
I dont get bugFix, I only point where the bug is.
While we wait how devteam fix this bug, you can use this fix.
It is attached browse_1. Unzip it and move and owerwrite to :
/components/com_virtuemart/themes/default/templates/browse

You see the attached file when you are logged in this forum


[attachment cleanup by admin]
Title: Re: [TRACKER 1882] Bug Report "No Image" link is wrong
Post by: iamalive on March 08, 2008, 13:22:57 PM
Hi Mauri

Thanks for this. I'ts appreciated!

regards
Title: Re: [TRACKER 1882] Bug Report "No Image" link is wrong
Post by: gregdev on March 08, 2008, 16:21:20 PM
OK. Try SVN rev. 1305. Also, please test this for products that have regular images and for products which use a URL for their images (I don't think URL images were working before).

Greg
Title: Re: [TRACKER 1882] Bug Report "No Image" link is wrong
Post by: mauri on March 08, 2008, 17:33:51 PM
Yes, it works all 3 ways. One thing, and its perfect. NO_IMAGE gets no width and height.
In shop_browse.php:
else {
$product_full_image = VM_THEMEURL.'images/'.NO_IMAGE;
}

edit to:
else {
$product_full_image = VM_THEMEURL.'images/'.NO_IMAGE;
$full_image_width = '200';
$full_image_height = '150';
}


I find that if you use full image URL, you cant use Auto-Create Thumbnail?
Title: Re: [FIXED] Bug Report "No Image" link is wrong
Post by: gregdev on March 09, 2008, 03:23:31 AM
QuoteI find that if you use full image URL, you cant use Auto-Create Thumbnail?

Correct - it does not work. I am working on it. It appears that it does everything right, then deletes the thumbnail image that was auto-created. So, it can't be that hard to fix - I just haven't found it yet. Will you enter this in the tracker?

Thanks,

Greg