VirtueMart Forum

VirtueMart 2 + 3 + 4 => Virtuemart Development and bug reports => Topic started by: cdbaron88 on October 11, 2024, 11:57:46 AM

Title: Hardcoded error message in order payment confirmation error
Post by: cdbaron88 on October 11, 2024, 11:57:46 AM
Hi,

Joomla 5.1.4 + VirtueMart 4.2.18 11050 + PHP 8.1

I'm experiencing some issues with the new PayPal plugin, but I'll address that in another thread that's already open.


For now, I've noticed that customers are receiving an untranslated error message. Specifically, "Checkout blocked by Payment plugin."

After looking into it, I found the following code in the file components/com_virtuemart/helpers/cart.php:1960


if($this->_blockConfirmedCheckout){
    VmInfo('Checkout blocked by Payment plugin');
    return false;
}

It seems that this message is hardcoded instead of using something like vmText::_('COM_VIRTUEMART_CART_CHECKOUT_BLOCKED_BY_PAYMENT_PLUGIN'); or something similar.

Best regards.