VirtueMart Forum

VirtueMart 2 + 3 + 4 => Virtuemart Development and bug reports => Topic started by: mauriziomomix on July 18, 2022, 00:36:04 AM

Title: Display modal popup upon 'Add to cart'
Post by: mauriziomomix on July 18, 2022, 00:36:04 AM
Hello,
I'm having some problems when disabling the Add to cart popup: it seems that the item can be added to cart only with the popup enabled.
No action (no add) starts with popup disabled.
Did anyone noticed/solved the same?
Thanks in advance
Maurizio

VirtueMart4.0.4
Title: Re: Display modal popup upon 'Add to cart'
Post by: GJC Web Design on July 18, 2022, 11:46:37 AM
yes-- this is currently being worked on .. 
Title: Re: Display modal popup upon 'Add to cart'
Post by: mauriziomomix on July 18, 2022, 18:33:38 PM
Thank you  ;)
Title: Re: Display modal popup upon 'Add to cart'
Post by: ml12 on July 18, 2022, 22:03:46 PM
Hello Maurizio,

I just came across your topic and I wanted to share with you that I had the same problem but I found a way to resolve it with a quick little tinkering.

I kept the popup option enabled and then, added a few CSS lines to hide the popup and its black overlay :

#fancybox-overlay{
  width:0%;
}

#fancybox-outer{
  display:none;
}


On my site, it works very well with this, no popup is showing up and items are added to the cart.

I hope this can help you while waiting for this issue to be resolved by VM :)

Mathias
Title: Re: Display modal popup upon 'Add to cart'
Post by: pinochico on July 18, 2022, 23:42:56 PM
Sorry,
but not showing popup for adding product in cart is mad idea
beause in this popup we added
- info about free shipping (how much I need buy for free shipping order yet)
- info about product which we want to buy too (standard lying motto - recommended)
- info about some product is added to cart automatically too (specially for shop with food - box for food)

I think we don't want shop without popup.
Mathias if you need, ok, hack css or core on your shop, is perfect.
Title: Re: Display modal popup upon 'Add to cart'
Post by: mauriziomomix on August 04, 2022, 23:09:15 PM
Hello pinochico,
I can understand your point of view but the setup allows the enabling or disabling the popup. If this is not correctly working, our opinion is marginal: the setup is broken.
Moreover, I have a project were I need that every time an item is added, the page stays ready for the next add.
It's boring for the user having to close the popup every time.
Title: Re: Display modal popup upon 'Add to cart'
Post by: hazael on August 05, 2022, 09:56:51 AM
QuoteIt's boring for the user having to close the popup every time.
You wrote as if the customer had to add something to the cart all day: D

Should you wish to not have a confirmation popup, you can make such a notification near the [add to cart] button without pop-up.
Generally, there should be some information about the action performed.
Title: Re: Display modal popup upon 'Add to cart'
Post by: pinochico on August 05, 2022, 10:13:31 AM
I often encounter that developers decide the features of an e-shop for customers.

Unfortunately, my experience in 15 years of making e-shops is that 100% of the time they have no idea what customers want.

Turning off the Add to Cart popup reduces the orientation of the e-shop and completely removes the marketing information that encourages further purchases.

Unfortunately, everyone has to go through this journey on their own and some people don't even start :)

Translated with www.DeepL.com/Translator (free version)
Title: Re: Display modal popup upon 'Add to cart'
Post by: mauriziomomix on August 14, 2022, 00:50:07 AM
Whatever we think about it, if the setup has "Yes" and "No", both should work. Not just one.

Moreover, I just installed the 4.0.4.10688 build... and it still has several bugs.
Is there someone that tests the release? I guess no.
And I guess because it's a free solution... but I'd rather pay to have a well working one.
Title: Re: Display modal popup upon 'Add to cart'
Post by: pinochico on August 14, 2022, 11:04:41 AM
I understand, and you're theoretically correct.
But there are few developers, their free version works 100%.

Most of the time it's just the opposite - what's free is usually broken (there are exceptions) and you can wait several years for a fix.

That's why we don't wait and if we really need fixes we do it ourselves programmatically and release our own versions, which we then use on websites and eshops.

But here I would rather wait for Max to get around to it.

Translated with www.DeepL.com/Translator (free version)
Title: Re: Display modal popup upon 'Add to cart'
Post by: GJC Web Design on August 14, 2022, 13:32:24 PM
@ mauriziomomix
QuoteIs there someone that tests the release? I guess no.

You don't seem to have any idea what is involved in testing a complex software like VM... of course all releases are tested along with the dozens of private dev releases before any public official ones...

There is only so much time that volunteers can give to the project .. have u volunteered your time to become a tester?
Title: Re: Display modal popup upon 'Add to cart'
Post by: Maurizio67 on August 14, 2022, 15:15:49 PM
I can do it if my job can be better considered than in this forum.
First of all: you are a tester? In this case, why EVERY (again EVERY) release contains a bug?
Second: Virtuemart is free, I know. But what is around Virtuemart causes royalties, so please stop thinking that free software can contain bugs with no consequences.
I use VM on several stores for my clients and now, at every update, I can't know if their store will follow be working correctly or not.
Do you ever ask yourself why many developers are leaving VM? I prefer VM, since several years. I pay for several products related to Virtuemart (Virtueplanet, Breakdesigns, Olwebdesign, and many others) so I contribute to the project in other ways.
If you think I can be useful for testing, why not? But my time, as much as yours, has to be considered to create value for the project.
Feel free to contact me here or at my technical email address supporto@bariweb.it.
But please don't say that a so "full of bug" release can be considered seriously tested. Is not respectful neither to me nor to you.

Regards
Maurizio
Title: Re: Display modal popup upon 'Add to cart'
Post by: pinochico on August 14, 2022, 16:11:41 PM
QuoteI use VM on several stores for my clients and now, at every update, I can't know if their store will follow be working correctly or not.

This is a somewhat manipulative way of looking at things.

It is up to you how you use free apps.
If you install them on a production site without testing and then post on the forum that something doesn't work, you are to blame for the problem on the customer site.
You need to remember that free apps, are free apps with all the benefits and problems.

We never install untested apps on a website.
Yes, we never trust the information on a released version that it is stable and we test on the development server.
Yes, we don't post here on the forum that something doesn't work, we fix any bugs ourselves.
Yes, we try not to use free apps, because then there is no guarantee that any bugs will be fixed by the manufacturer.
Yes, we try to use our own apps as much as possible and don't rely on other developers.

If you do the same, your posts here on the forum regarding bugs will be fewer and fewer.

But this is one of the basic rules of software development, and it amazes me greatly that every week there is someone here who is in a state of seventh WONDER of the world.
It shows their irresponsibility and unprofessionalism.

Don't automatically expect professionalism in free apps or you will be disappointed.

(That's also why we use J3 and VM 3.4.2 or VM 3.8.9)

Translated with www.DeepL.com/Translator (free version)
Title: Re: Display modal popup upon 'Add to cart'
Post by: ssc3 on August 14, 2022, 16:46:58 PM
The problem with the Display modal popup upon 'Add to cart' was caused by VM 4.0.6

This was first noted on the day of it's release.

https://forum.virtuemart.net/index.php?topic=148569.0

It resulted from changes to vrequest.php.

Since there was no VM 4.0.5 released. No one had a chance to test.

It went straight to 4.0.6 and marked stable.

Apparently there is a VM 4.0.7 available which fixes this but that has not been published either.

If Virtuemart do not publish release candidates how can the wider community test.
Title: Re: Display modal popup upon 'Add to cart'
Post by: Maurizio67 on August 14, 2022, 23:37:40 PM
Thanks for your contribution ssc3
Title: Re: Display modal popup upon 'Add to cart'
Post by: Maurizio67 on August 14, 2022, 23:47:52 PM
Quote from: pinochico on August 14, 2022, 16:11:41 PM

This is a somewhat manipulative way of looking at things.


I think the same after your first answer.
I wrote about a non-working setting and your answer has been something like "the setting is useless".
As we both can see, another member has brought a more relevant contribution.

PS: Regarding the fact that the component is free ... I would prefer it to be paid and with reliable assistance, rather than free and with a belligerent and inaccurate community.
Title: Re: Display modal popup upon 'Add to cart'
Post by: GJC Web Design on August 16, 2022, 10:07:23 AM
QuoteSince there was no VM 4.0.5 released. No one had a chance to test.

odd numbered versions are always dev versions and will only appear (if at all) on the https://dev.virtuemart.net/projects/virtuemart/files
Title: Re: Display modal popup upon 'Add to cart'
Post by: ssc3 on August 16, 2022, 13:50:09 PM
Quote from: GJC Web Design on August 16, 2022, 10:07:23 AM
odd numbered versions are always dev versions and will only appear (if at all) on the https://dev.virtuemart.net/projects/virtuemart/files

That's what I assumed, the odd numbered version were dev versions.

They used to appear for VM 3, but none since.

If VM 4.0.6 had been released as VM 4.0.5 and labelled dev, test, beta or release candidate the problems with it might have been picked up.

The issues with VM 4.0.6 were actually found on the day of its release.

At the moment VM 4.0.6 is labelled "Stable" and on the Admin download,  but has a critical issue which will break a store.

Some of those upgrading will lose there ability to take orders.

It's not helping with Virtuemart's reputation for reliability.
Title: Re: Display modal popup upon 'Add to cart'
Post by: GJC Web Design on August 16, 2022, 16:49:02 PM
@ ssc3

Sadly I can only agree with your comments ..  but Max is the gatekeeper for all releases so until he is back on the 26th Aug it is what it is ..
We can only hope users check the forums before updating to get a flavour of the releases acceptance...
Title: Re: Display modal popup upon 'Add to cart'
Post by: Mike J on August 17, 2022, 04:56:25 AM
Thanks for that info ssc3 & GJC Web Design (and others who are making a positive contribution here),

So good to see your comments. You guys really do have VMs best interests at heart.

Knowing that Max is back on the 26th makes a big difference.

Thank you again.
Title: Re: Display modal popup upon 'Add to cart'
Post by: Maurizio67 on August 17, 2022, 09:37:05 AM
Hi all, thanks for your contribution.
Re-reading my messages I realize that they may seem controversial and unproductive but it was not my intention. My problem is the need to use reliable solutions and not run the risk of blocking working sites. In my experience VM is the best solution so far, even compared to non-free solutions. By publishing here I try to make my contribution.
Max is coming back on 8/26? Hope better after that date.
Thank you
Title: Re: Display modal popup upon 'Add to cart'
Post by: GJC Web Design on August 17, 2022, 12:09:06 PM
I can post VirtueMart 4.0.7 10693 here if anyone wants to test it....
Title: Re: Display modal popup upon 'Add to cart'
Post by: ssc3 on August 17, 2022, 16:51:34 PM
Quote from: GJC Web Design on August 17, 2022, 12:09:06 PM
I can post VirtueMart 4.0.7 10693 here if anyone wants to test it....
Yes, please post.

Heard that much it about, I think we will have to see it now.
Title: Re: Display modal popup upon 'Add to cart'
Post by: GJC Web Design on August 17, 2022, 17:22:32 PM
QuoteHeard that much it about, I think we will have to see it now.
;D

Bollocks ...  too large to post here... sigh

you should be able to get it from here

https://filetransfer.io/data-package/VNS6Sxn2#link



Title: Re: Display modal popup upon 'Add to cart'
Post by: Maurizio67 on August 17, 2022, 20:55:37 PM
Thank you GJC Web Design
Title: Re: Display modal popup upon 'Add to cart'
Post by: Maurizio67 on August 17, 2022, 22:40:24 PM
Hello, I am testing...
During setup, it results missing the TCDP so I loaded the com_tcpdf_1.2.2.
After this, I have a message about missing some plugins related to payment and shipping: AIO is needed.
In the repository the last one is com_virtuemart.4.0.4.10688_ext_aio. Which release is the correct one?
Thanks in advance
Maurizio
Title: Re: Display modal popup upon 'Add to cart'
Post by: GJC Web Design on August 17, 2022, 22:43:27 PM
afaik there are no changes to the AIO or TCP so just use the latest 4.0.4
Title: Re: Display modal popup upon 'Add to cart'
Post by: ssc3 on August 18, 2022, 16:03:11 PM
Quote from: GJC Web Design on August 17, 2022, 17:22:32 PM

you should be able to get it from here

https://filetransfer.io/data-package/VNS6Sxn2#link

Installed 4.0.7 over 4.0.6

Initially a "protected method" error but managed to find a way round that.

From the point of view of this thread, the "Display modal popup upon 'Add to cart' problem is fixed.

However if returning from a payment server using GET the order complete page while readable was unformatted.

Refreshing the page fixed this.

So two identical GET's in succession.

First one showed format errors.

The second worked as expected.

Payments methods that use POST for the return seem to work correctly.

It looks like there are only formatting problems left to solve for the checkout, nothing that will stop a transaction.