VirtueMart Forum

VirtueMart 2 + 3 + 4 => Virtuemart Development and bug reports => Topic started by: maxispin on December 12, 2016, 17:42:49 PM

Title: weight_countries.php - No price shown product page [change from 3.0.17+]
Post by: maxispin on December 12, 2016, 17:42:49 PM
/plugins/vmshipment/weight_countries/weight_countries.php

Change made in 3.0.17.2 made Product price disappear. This occurs when product has no real price set and it is computed from subproducts. (I know this is related to the plugin I have (ty S42), but still wondering why it happens. )

See attachments.





3.0.173.0.17+
if(!isset($cart)){ 
                 $cart = VirtueMartCart::getCart(); 
                 $cart->products['virtual'] = $product; 
                 $cart->_productAdded = true; 
                 $cart->prepareCartData(); 
             }
      
if(!isset($cart)){        
                   $cart = VirtueMartCart::getCart();        
                   $cart->prepareCartData();        
               }       
               $prices=array('salesPrice'=>0.0);        
               if(isset($cart->cartPrices)){        
                   $prices['salesPrice'] = $cart->cartPrices['salesPrice'];        
               }       
               if(isset($product->prices)){        
                   $prices['salesPrice'] += $product->prices['salesPrice'];        
               }       
      
               if($this->checkConditions($cart,$this->_currentMethod,$prices,$product)){
[td

Title: Re: weight_countries.php - No price shown product page [change from 3.0.17+]
Post by: Studio 42 on December 12, 2016, 21:47:12 PM
Valerie informed me that it's not the only plugin having problem seens(not only for price calc).
I waited for a new Stable release before changing something, because it's not the only case having this problem and each new release have new code changes.
But vm3.0.16.2 is very stable, simply do not use vm3.0.18 for now, if you don't need it.
Title: Re: weight_countries.php - No price shown product page [change from 3.0.17+]
Post by: maxispin on December 13, 2016, 08:27:43 AM
Thank you Studio42 for responding! Good to know what version is most stable. I test with the newest version with my hack and roll back if I found any severe problems.
Title: Re: weight_countries.php - No price shown product page [change from 3.0.17+]
Post by: Milbo on December 15, 2016, 14:49:12 PM
Atm I think Patrick agrees that http://dev.virtuemart.net/attachments/download/1037/com_virtuemart.3.0.18.6_extract_first.zip is most stable.