VirtueMart Forum

VirtueMart 2 + 3 + 4 => Virtuemart Development and bug reports => Topic started by: lindapowers on October 14, 2015, 19:07:19 PM

Title: Tax includes: Order email
Post by: lindapowers on October 14, 2015, 19:07:19 PM
Hi

Since we updated to VM 3.010 in our order emails right under the total appears that text, tax includes:

And no value, I wonder from where does that come and if its supposed to show some value or does it just mean that tax is included.

We use tax type in our rules.
Title: Re: Tax includes: Order email
Post by: Milbo on October 14, 2015, 19:31:47 PM
hmmm, it is meant to display the complete tax seperated by tax type. In case you have more than one tax. Hmm,
Title: Re: Tax includes: Order email
Post by: lindapowers on October 21, 2015, 00:11:58 AM
Appears like this to us, with no values:

(http://s15.postimg.org/akk467taj/taxinc.jpg)

Is there a setting for it in backed or something that could affect the display?

Regards


Title: Re: Tax includes: Order email
Post by: Marin on February 21, 2016, 15:08:13 PM
Hi guys,
Any update on this?

In the invoice_items.php there is the following code:

if(isset($taxBill[$rule->virtuemart_calc_id])){
         $taxBill[$rule->virtuemart_calc_id]->calc_amount += $r->calc_amount;
      } else {
         $taxBill[$rule->virtuemart_calc_id] = $r;

And I paste it because

if($taxBill){
      ?><tr >
         <td colspan="7"  align="right" class="pricePad"><?php echo vmText::_('COM_VIRTUEMART_TOTAL_INCL_TAX') ?> </td>

And according to the language file COM_VIRTUEMART_TOTAL_INCL_TAX="Tax includes:"

So my question is where on the Backend to set this parameter taxBill?

One way would be to "hack" the php file and to remove the code that prints the Tax includes.
Another way might be to modify or override the language file en-GB.com_virtuemart.ini or whatever language you are using and COM_VIRTUEMART_TOTAL_INCL_TAX="", but I haven't tested it yet.

Thanks :)
Title: Re: Tax includes: Order email
Post by: lindapowers on February 21, 2016, 19:27:19 PM
We use the overrides from Spyros https://www.virtuemarttemplates.eu/virtuemart-templates/virtuemart-order-emails.html which show e-mails nice and clean so we never really found out the reason for the issue we posted here some months ago.

Regards
Title: Re: Tax includes: Order email
Post by: Marin on February 21, 2016, 19:58:39 PM
It is good that you use a third-party product which requires a purchase :) But imagine there are people out there who actually would like to find a solution without paying. Believe me, it is not about the 10 euros, it is about the principle.
Title: Re: Tax includes: Order email
Post by: SparksArts on February 21, 2016, 20:09:31 PM
It's a Virtuemart bug. We should help them fix it, not work around it.
Title: Re: Tax includes: Order email
Post by: lindapowers on February 21, 2016, 22:29:28 PM
Quote from: Marin on February 21, 2016, 19:58:39 PM
It is good that you use a third-party product which requires a purchase :) But imagine there are people out there who actually would like to find a solution without paying. Believe me, it is not about the 10 euros, it is about the principle.

Oh you want it all for free, good luck in the virtuemart world ;)

Quote from: SparksArts on February 21, 2016, 20:09:31 PM
It's a Virtuemart bug. We should help them fix it, not work around it.

Good, waiting for your fix so they can add it to the core.
Title: Re: Tax includes: Order email
Post by: Milbo on February 22, 2016, 20:14:56 PM
I think that is solved already. Did someone test this with vm3.0.13.4 ?
Title: Re: Tax includes: Order email
Post by: betterlead on March 06, 2016, 01:07:57 AM
I still got it. I am sorry to say.
Have 3.0.13.4. But remember, you installed special fix for me. Perhaps...

Skickat från min LG-H815 via Tapatalk

Title: Re: Tax includes: Order email
Post by: lindapowers on March 29, 2016, 22:09:56 PM
I can't check if the tax display in list mode still happens in the emails since we use the overrides by Spyros but what I noticed after updating from 3.0.12 to 3.0.14 is that in the order details in the backend you now get the listing of the tax of each product as the image shows.

(https://i.imgsafe.org/9b51623.jpg)