VirtueMart Forum

VirtueMart 2 + 3 + 4 => Virtuemart Development and bug reports => Topic started by: poisom on May 30, 2015, 13:08:27 PM

Title: Bug in classes declaration on virtuemart admin files!
Post by: poisom on May 30, 2015, 13:08:27 PM
Please make the appropriate fixes because now virtuemart conflicts with some other plugins i use in administrator panel.

So on file:
     /administrator/components/com_virtuemart/views/product/tmpl/product_edit_information.php

line 44
        <input class="required" type="text" class="inputbox"  name="product_name" id="product_name" value="<?php echo $this->product->product_name?>" size="32" maxlength="255" />

should be
        <input class="required inputbox" type="text" name="product_name" id="product_name" value="<?php echo $this->product->product_name?>" size="32" maxlength="255" />

on file:
        /administrator/components/com_virtuemart/views/product/tmpl/product_edit_price.php

line 28
        <table class="adminform" class="productPriceTable">

should be
        <table class="adminform productPriceTable">



You have to use multiple classes inside the class attribute, separated by whitespace and not in different class attribute. This is the W3C HTML5 recommendation (http://www.w3.org/TR/html5/dom.html#classes).

Please let me know if and when you will implement those fixes!
Thank you!
Title: Re: Bug in classes declaration on virtuemart admin files!
Post by: Milbo on June 01, 2015, 11:41:12 AM
is implemented, I see that as a kind of typo. We all know how it should be, thank you. If you find more, dont hesitate to tell us.
Title: Re: Bug in classes declaration on virtuemart admin files!
Post by: nppsbh on June 02, 2015, 13:56:42 PM
Hi.
Found some more typos

file
/administrator/components/com_virtuemart/views/product/tmpl/product_edit_price.php
line 28
<table class="adminform" class="productPriceTable">

file
/administrator/components/com_virtuemart/views/product/tmpl/product_edit_customer.php
line 45, 46
</div>
</label>

should be
</label>
</div>


line 61
missing </div>

file
/administrator/components/com_virtuemart/views/product/tmpl/product_edit_information.php
line 255 remove </tr>
line 282~291 shouldn't it be inside a table?

file
/administrator/components/com_virtuemart/views/product/tmpl/product_edit_custom.php
line 144 think is missing a closing div

In shop->shop and configuration->configuration there are also some typos
Title: Re: Bug in classes declaration on virtuemart admin files!
Post by: Milbo on June 03, 2015, 09:43:58 AM
Thank you, yepp. Good work,... wow some of these are really old. The "problem" is here the autocorrection of the browsers.