VirtueMart Forum

VirtueMart 2 + 3 + 4 => Virtuemart Development and bug reports => Topic started by: Ronny Buelund on January 15, 2014, 08:07:32 AM

Title: Bug in 2.0.26d!
Post by: Ronny Buelund on January 15, 2014, 08:07:32 AM
After updating to 2.0.26d i cannot get past the "select payment method" the system is stuck there! I restored my site and went back to 2.0.26a - now it works again - Please help
Title: Re: Bug in 2.0.26d!
Post by: Milbo on January 15, 2014, 10:44:03 AM
Heyho, I think you are using the OPC (one page checkout) option and miss to edit your layout a bit, please read here

http://forum.virtuemart.net/index.php?topic=120943.0
Title: Re: Bug in 2.0.26d!
Post by: Ronny Buelund on January 15, 2014, 11:36:37 AM
But i allready did that modification in my override file in the template !?? So why does it not work after updating - the file is still in the template. Has there been other modifications to the view files since 2.0.26a ??
Title: Re: Bug in 2.0.26d!
Post by: jjk on January 15, 2014, 13:10:42 PM
Occationally it is a good idea to test with the original file(s) and if that works, re-apply your customizations and save it as your new override. But maybe you did try that already?
Title: Re: Bug in 2.0.26d!
Post by: z-analysts on January 15, 2014, 16:22:34 PM
Did you update OPC with the latest version? It specifically supports the 26d release of VM.
Title: Re: Bug in 2.0.26d!
Post by: jjk on January 15, 2014, 17:52:24 PM
Quote from: z-analysts on January 15, 2014, 16:22:34 PM
Did you update OPC with the latest version? It specifically supports the 26d release of VM.
Of course that applies only if he is using a third party OPC. I would assume the overrides were for VM2's built-in OPC.
Title: Re: Bug in 2.0.26d!
Post by: Ronny Buelund on January 15, 2014, 18:36:35 PM
Exactly "the overrides were for VM2's built-in OPC." - so that is not the problem.
Title: Re: Bug in 2.0.26d!
Post by: Ronny Buelund on January 15, 2014, 20:19:59 PM
Well now i found this difference in my template override and the 2.0.26d file default_pricelist.php

My override      if (VmConfig::get('oncheckout_opc', 0))
Line in 2.0.26d              if (VmConfig::get('oncheckout_opc', 1))

I changed the 0 to 1 in my template override - but the problem is still there - the checkout process hangs at the payment selection - which should not be there at all as there is only one payment possibility !


I also noticed that this code:

      if ($this->checkout_task) {
         $taskRoute = '&task=' . $this->checkout_task;
      }
      else {
         $taskRoute = '';
      }
which is mentioned earlier in this post still is in default.php in version 2.0.26d - just later in the file on line 135 - is this correct ??


Please help asap !
Title: Re: Bug in 2.0.26d!
Post by: jjk on January 15, 2014, 23:35:30 PM
I couldn't reproduce your problem on my 2.0.26d version. I'm using an override for default_pricelist.php, too. However, I didn't update my 2.0.26a default_pricelist override to the latest 2.0.26d version yet (still using the 2.0.26a override in 2.0.26d), but both versions are working for me.

In 2.0.26d there are 3 occurences of 'if (VmConfig::get('oncheckout_opc', 1))' in the file default_pricelist.php and also in the file view.html.php. Perhaps you missed to change them all to 'if (VmConfig::get('oncheckout_opc', 0))' ?

BTW - what happens with your cart if you keep the original 'if (VmConfig::get('oncheckout_opc', 1))'? I don't see any difference if I change ...1)) to ...0))
Sorry for the last question, but I'm php illiterate  :)

Concerning the payment selection - do you have automatic payment selection enabled in VM Configuration > Checkout tab?
Title: Re: Bug in 2.0.26d!
Post by: Milbo on January 16, 2014, 00:01:24 AM
the second parameter changes nothing! It is the default parameter which is only used if there is no config, which should never be the case
Title: Re: Bug in 2.0.26d!
Post by: Ronny Buelund on January 16, 2014, 05:25:56 AM
Well - then there is still a bug here!
Title: Re: Bug in 2.0.26d!
Post by: Ronny Buelund on January 16, 2014, 10:49:50 AM
Just want to point out - that this worked perfectly before the update to 2.0.26d - that be on version 2.0.26a - so the problem must be in the update. I remember changing something in config.php, because of some write permissions - that was on another thread in the forum (http://forum.virtuemart.net/index.php?topic=121130.msg413744#msg413744) - could that be the problem - that those changes have been overwritten by the update ?? I thought that theese changes where added to the update ??
Title: Re: Bug in 2.0.26d!
Post by: Milbo on January 16, 2014, 12:40:53 PM
When you disable your overrides for the cart, it should directly work. The OPC option in vm is not a real OPC. There is no ajax or so. It just helps to create nice OPCs. So if you dont know how to layout it, use no OPC and wait for vm2.2, which is on the way. The test version vm2.1 is already released http://forum.virtuemart.net/index.php?topic=119177.msg414710#msg414710
Title: Re: Bug in 2.0.26d!
Post by: Ronny Buelund on January 16, 2014, 17:36:48 PM
I have deactivated OPC and now it works.