VirtueMart Forum

VirtueMart 2 + 3 + 4 => Virtuemart Development and bug reports => Topic started by: vasena on October 16, 2013, 08:51:33 AM

Title: Possible disadvantages of development
Post by: vasena on October 16, 2013, 08:51:33 AM
During development patterns I have find a few disadvantages:
1. When a product have no image, you can not set reference parameters
(line 478, file mediahandler.php)
Must be replaced:
return $ this-> displayIt ($ file_url, $ file_alt, $ imageArgs, $ lightbox);
with:
return $ this-> displayIt ($ file_url, $ file_alt, $ imageArgs, $ lightbox, $ effect);
2. If you re-use vmelements in the module settings, the element is not only a list of caches but also the value
(line 737, file shopfunctions.php)
Most likely you need to cache along with the selected value
PS line numbers is taken from the documentation for version 2.0.16
Title: Re: Possible disadvantages of development
Post by: Milbo on October 17, 2013, 20:27:26 PM
Please explain further, and from where comes $effect?
Title: Re: Possible disadvantages of development
Post by: vasena on October 21, 2013, 08:42:39 AM
You can view documentation for $effect: http://docs.virtuemart.net/api-vm2/db/d4c/mediahandler_8php_source.html#l00466
What further you want to know???
Title: Re: Possible disadvantages of development
Post by: Milbo on October 23, 2013, 11:18:17 AM
I added it. Maybe people scream now, because the standard effect is now always set.