VirtueMart Forum

VirtueMart 2 + 3 + 4 => Virtuemart Development and bug reports => Development & Testing => Topic started by: slammy on September 10, 2013, 12:02:22 PM

Title: small bug? (loop) with additional images in 2.0.22c
Post by: slammy on September 10, 2013, 12:02:22 PM
Hi,

I am currently running jml 2.5.14 and vm sr 2.0.22c at my live-site

I think I´ve found a small bug(?) in 2.0.22c -> concerning additional-Images in components/com_virtuemart/views/productdetails/default_images.php, which is loading at components/com_virtuemart/views/productdetails/tmpl/Default.php with loadTemplate('images');

I have some products with multiple Images:

If I have 5 additional images on a product, all five images will be repeated 5 times.

I found a "for-loop" at components/com_virtuemart/views/productdetails/default_images.php:

<div class="additional-images">
                <?php
                
for ($i 0$i $count_images$i++) {
                        
$image $this->product->images[$i];
                        
?>

            <div class="floatleft">
                    <?php
                        
echo $image->displayMediaFull('class="product-image" style="cursor: pointer"',false,"");
                    
?>

            </div>
                        <?php
                
}
                
?>



Additional Images will be shown only onetime if I set the Loop to 0

for ($i = 0; $i < 0; $i++) (alternatively you can comment it out!)
This worked for me.

Seems that the loop handles all additional images in one, and repeats them x-times - equals to the amount of additional images you have.

regards jens 


[attachment cleanup by admin]