VirtueMart Forum

VirtueMart 2 + 3 + 4 => Virtuemart Development and bug reports => Topic started by: Jason Farmer on October 27, 2012, 17:44:38 PM

Title: rfc - helpful change to assist in styling payment confirmation pages etc
Post by: Jason Farmer on October 27, 2012, 17:44:38 PM
request for change - helpful change to assist in styling payment confirmation pages etc

vm2.012b

/administrator/components/com_virtuemart/plugins/vmpsplugin.php line 810
$html = "<tr >\n<td " . $class . ">" . $key_text . "</td>\n <td align='left'>" . $value . "</td>\n</tr>\n";


the css class is applied to the first cell in the row, would much prefer it to be applied to the whole row (as css does not have a parent selector at the moment..)  and change the first cell to be a th - all makes much more sense symantically (imho)...
would also be good to remove the 'align="left"' style - if you're going to create html in core files, please make it so that we can style it freely.

ie.
$html = "<tr " . $class . "><th>" . $key_text . "</th><td>" . $value . "</td></tr>\n";


Thanks