VirtueMart Forum

VirtueMart 2 + 3 + 4 => Virtuemart Development and bug reports => Topic started by: mb000000 on October 18, 2012, 10:51:12 AM

Title: Minor HTML clean up in default_pricelist.php
Post by: mb000000 on October 18, 2012, 10:51:12 AM
VM: 2.0.12b

In (front end) views/cart/tmpl/default_pricelist.php around lines 130 et seq there are some instances of unclosed <span>s (plural of span).  I'm sure most browsers aren't choking too badly over them but it won't hurt to fix them.  This applies to the lines displaying COM_VIRTUEMART_CART_SUBTOTAL_TAX_AMOUNT and COM_VIRTUEMART_CART_SUBTOTAL_DISCOUNT_AMOUNT. In my installation, I've also wrapped the line displaying COM_VIRTUEMART_CART_TOTAL in a span to control the right alignment, but that's just for my situation.

Sorry if this is a bit picky!

Mark
Title: Re: Minor HTML clean up in default_pricelist.php
Post by: mb000000 on December 06, 2012, 13:42:05 PM
VM 2.0.14

Revisiting my earlier post and rechecking my supposed fixes, I see that the alignment problem is more widespread than I thought. As far as I can tell, with "most" browsers handling of HTML5, the align attribute of the th element is ignored, which means in default_pricelist.php, the column headers don't align as one might expect (okay, okay, this really IS minor, I know).  My solution / workaround is simply to add to the th elements (leaving the existing aligns as is) style="text-align:right;", for example.

This means the earlier spans I added can be removed to achieve the effect "properly".  Would be good if these mods made it into the next release.

Thanks

Mark
Title: Re: Minor HTML clean up in default_pricelist.php
Post by: Milbo on December 18, 2012, 16:52:39 PM
Please download the latest 2.0.15e, then apply your fixed and upload the file here. Then I can add it.