VirtueMart Forum

VirtueMart 2 + 3 + 4 => Virtuemart Development and bug reports => Topic started by: zebrafilm on April 17, 2012, 13:55:00 PM

Title: [BUG?] VM 2.06 can't switch off price override
Post by: zebrafilm on April 17, 2012, 13:55:00 PM
Just installed VM2.06 over  2.04. Switched off all Tax/discount rules to get a clear picture but now I am unable to switch of the Price override in the products.
When I un-tick the option, it comes back after a save. I deleted the values but then it comes back to zero.
Same happens when I clone the product.
When I create a new product price override is unselected and I can keep it when I save the product, but the moment I have selected it and want to switch off again I get stuck again.

Extra installed plugins: vmcalculation

Title: Re: [BUG?] VM 2.06 can't switch off price override
Post by: Milbo on April 17, 2012, 15:52:10 PM
The value stays, but should not be used, when not checked.
Title: Re: [BUG?] VM 2.06 can't switch off price override
Post by: lukelee on April 18, 2012, 08:00:09 AM
same problem here.
Title: Re: [BUG?] VM 2.06 can't switch off price override
Post by: serapol on April 18, 2012, 08:34:55 AM
I confirm this problem exists. Unable to turn off the override
Title: Re: [BUG?] VM 2.06 can't switch off price override
Post by: serapol on April 18, 2012, 09:40:28 AM
Solving the problem

The file administrator / components / com_virtuemart / tables / product_prices.php line 43

Replace
var $ override = null;
on
var $ override = 0;
Title: Re: [BUG?] VM 2.06 can't switch off price override
Post by: zebrafilm on April 19, 2012, 13:09:08 PM
Works for me too. Thanks!
Title: Re: [BUG?] VM 2.06 can't switch off price override
Post by: Jeff Marsh Photo on April 20, 2012, 09:07:23 AM
Quote from: serapol on April 18, 2012, 09:40:28 AM
Solving the problem

The file administrator / components / com_virtuemart / tables / product_prices.php line 43

Replace
var $ override = null;
on
var $ override = 0;

Genius! Thank you, it has saved me a serious headache...  8)
Title: Re: [BUG?] VM 2.06 can't switch off price override
Post by: BonaFide on April 24, 2012, 17:32:19 PM
Thanks Serapol. Was pulling my hair out.

Now just to resolve the Internet Explorer issues and I might be able to get this shop up and working for its money......
Title: Re: [BUG?] VM 2.06 can't switch off price override
Post by: Milbo on April 24, 2012, 23:39:48 PM
too early guys,

you will get problems with overrides from the parent and similar. The real error was a wrong checkbox. Anyway, I added now also an override for discount before price. Problem is atm it is not setting the final one.
Next beta release is soon, with the bugfixes.
Title: Re: [BUG?] VM 2.06 can't switch off price override
Post by: curlz on April 30, 2012, 09:06:31 AM
Thanks Serapol, it worked! I had tried everything.
@ Milbo does it break anything to use this fix? I was in a tight spot with a site launch coming up.
Title: Re: [BUG?] VM 2.06 can't switch off price override
Post by: Milbo on April 30, 2012, 12:14:42 PM
No should not, we plan a release, which should not contain any changes to layouts or similar.
Title: Re: [BUG?] VM 2.06 can't switch off price override
Post by: resorter on May 07, 2012, 08:17:16 AM
Hi guys,

well with this solution i can check and uncheck the override at admin panel but when is unchecked at fronted override stays visible and display the base price with tax!!!
Title: Re: [BUG?] VM 2.06 can't switch off price override
Post by: Milbo on May 07, 2012, 12:22:52 PM
I think this happens, because you use parent products for it, which is right. I will upload today a new beta, which has this fixed.
Title: Re: [BUG?] VM 2.06 can't switch off price override
Post by: resorter on May 07, 2012, 14:57:52 PM
Hi, thanks for your reply, will you post it here or at general updates?
Title: Re: [BUG?] VM 2.06 can't switch off price override
Post by: Milbo on May 08, 2012, 14:04:52 PM
It is fixed in the svn since some days. Use this version http://dev.virtuemart.net/attachments/download/419/com_virtuemart.2.0.7.a_extract_first.zip

Be aware that it has slightly bugs in when storing a parent with childs (overwriting categories of childs).
Title: Re: [BUG?] VM 2.06 can't switch off price override
Post by: resorter on May 08, 2012, 14:13:09 PM
HI, do you know which part of code is for the override because i have made many, many, many modifications and replacing files will very painfull
Thanks
Title: Re: [BUG?] VM 2.06 can't switch off price override
Post by: Milbo on May 08, 2012, 15:31:11 PM
Ohh, that is bad. You should learn to create your modifications as overrides or plugin. At least you should not modify the files of the BE. The changes are in the BE views, model and so on.
Title: Re: [BUG?] VM 2.06 can't switch off price override
Post by: resorter on May 08, 2012, 18:30:03 PM
Hi again,
well i replaced all files but the option disable still not working, display final base price with tax, twice
Title: Re: [BUG?] VM 2.06 can't switch off price override
Post by: Milbo on May 08, 2012, 18:34:16 PM
??
calculationh.php also got updated.
Title: Re: [BUG?] VM 2.06 can't switch off price override
Post by: resorter on May 08, 2012, 18:38:45 PM
Yes, i saw it, but i can't disable override
Title: Re: [BUG?] VM 2.06 can't switch off price override
Post by: Milbo on May 08, 2012, 19:18:10 PM
You should have 3 options

Disabled
Overwrite final
Overwrite price to tax
Title: Re: [BUG?] VM 2.06 can't switch off price override
Post by: resorter on May 08, 2012, 20:06:07 PM
Yes i have, but disable option isn' work properly, the override price is disabled but in price field at fronted display again the final price
Title: Re: [BUG?] VM 2.06 can't switch off price override
Post by: Milbo on May 08, 2012, 20:37:51 PM
ah, but that is something different, then.