Author Topic: Minor Bug in VM rev5868 when adding items to the cart  (Read 10131 times)

patrik60

  • Guest
Minor Bug in VM rev5868 when adding items to the cart
« on: April 13, 2012, 17:52:28 pm »
Hello

There is a minor bug with the new possibility enabling or disabling popup.

When enabled, cart changes into default site language after adding items. When disabled, the message appears twice.

[attachment cleanup by admin]

patrik60

  • Guest
Re: Minor Bug in VM rev5868 when adding items to the cart
« Reply #1 on: April 17, 2012, 17:48:35 pm »
Problem not solved in 2.0.6 stable.

patrik60

  • Guest
Re: Minor Bug in VM rev5868 when adding items to the cart
« Reply #2 on: April 20, 2012, 09:29:02 am »
I have attached now three pics to demonstrate the problem in an multiligual shop when "Display modal popup upon 'Add to cart' " is enabled:

Starting in English when adding an item to the cart, the cart-modul content changes into German. After refreshing the browser it changes back into english. Also the content of the popup changes into German (see pic in my first post).

[attachment cleanup by admin]

Milbo

  • Virtuemart Projectleader
  • Administrator
  • Super Hero
  • *
  • Posts: 10283
  • VM3.9 Eagle Owl
    • VM3 Extensions
  • VirtueMart Version: VirtueMart 3 on joomla 3
Re: Minor Bug in VM rev5868 when adding items to the cart
« Reply #3 on: April 20, 2012, 19:04:06 pm »
There is a new option in the vmconfig tab cart "language Javascript Fix"
Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

patrik60

  • Guest
Re: Minor Bug in VM rev5868 when adding items to the cart
« Reply #4 on: April 20, 2012, 19:07:25 pm »
When selecting this option I can't add any item to the cart in the non default language.

patrik60

  • Guest
Re: Minor Bug in VM rev5868 when adding items to the cart
« Reply #5 on: April 21, 2012, 16:48:22 pm »
To me it seems not to be a language problem. I have also made a template override of the cart modul. There I have deleted item prices and cart attributes. They appear again after adding something to the cart. Only after refreshing it looks correctly.



[attachment cleanup by admin]

patrik60

  • Guest
Re: Minor Bug in VM rev5868 when adding items to the cart
« Reply #6 on: April 28, 2012, 13:36:56 pm »
Quote
Starting in English when adding an item to the cart, the cart-modul content changes into German. After refreshing the browser it changes back into english. Also the content of the popup changes into German

It's a SEO problem. When disabling SEO in Joomla configuration it works. When disabling it only in VM configuration the problem remains.

patrik60

  • Guest
Re: Minor Bug in VM rev5868 when adding items to the cart
« Reply #7 on: May 02, 2012, 16:15:32 pm »
Finally I have found the problem:

There is an option in plugin System - Language Filter: Remove URL Language Code. As soon as this option is set to YES, the behaviour of the popup is going wrong as I tried to describe im my posts. When the setting is set to NO the popup is working correctly.


patrik60

  • Guest
Re: Minor Bug in VM rev5868 when adding items to the cart
« Reply #8 on: May 27, 2012, 13:34:57 pm »
Is there any solution for this issue?

Milbo

  • Virtuemart Projectleader
  • Administrator
  • Super Hero
  • *
  • Posts: 10283
  • VM3.9 Eagle Owl
    • VM3 Extensions
  • VirtueMart Version: VirtueMart 3 on joomla 3
Re: Minor Bug in VM rev5868 when adding items to the cart
« Reply #9 on: June 01, 2012, 18:57:06 pm »
You told the solution for the issue. It is a joomla thing. People must choose the right option. Thx for digging in and finding it. Now is the question, where to place it? Which part of the manual? Maybe a special "multilanguage manual" would be good.
Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

patrik60

  • Guest
Re: Minor Bug in VM rev5868 when adding items to the cart
« Reply #10 on: June 04, 2012, 16:50:09 pm »
Quote
You told the solution for the issue.

I don't agree with you. I didn't tell the solution but I told the problem. It can't be a solution to disable a part of the Joomla functions to make working a component properly.
Someone of the dev team was telling me also some time ago, that I haven't understood the multilanguage function of Joomla because the language suffix in the default language of my site was missing. Believe me, it's hard to be taken as a dummy, because I'm using (or in case of VM try to use) a new offered option of Joomla.

Did you know about this option before? Is it hard to consider this option in VM? Yes, this is the part where I don't have any idea, because I'm a user and not a developer. I would appreciate it very much if there could be a way to include this option into VM.

Regards
Patrik

Milbo

  • Virtuemart Projectleader
  • Administrator
  • Super Hero
  • *
  • Posts: 10283
  • VM3.9 Eagle Owl
    • VM3 Extensions
  • VirtueMart Version: VirtueMart 3 on joomla 3
Re: Minor Bug in VM rev5868 when adding items to the cart
« Reply #11 on: June 05, 2012, 10:43:03 am »
Finally I have found the problem:
There is an option in plugin System - Language Filter: Remove URL Language Code. As soon as this option is set to YES, the behaviour of the popup is going wrong as I tried to describe im my posts. When the setting is set to NO the popup is working correctly.

I don't agree with you. I didn't tell the solution but I told the problem. It can't be a solution to disable a part of the Joomla functions to make working a component properly.

This is contrary what you say. You describe above, when you let the feature ENABLED, then it works. So in my eyes you are like someone saying, HEy they ABS of my car isnt working, when I disable it.

Yes that is absolutly correct, when you disable the URL language code, of course it will fail.
Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

patrik60

  • Guest
Re: Minor Bug in VM rev5868 when adding items to the cart
« Reply #12 on: June 05, 2012, 18:09:04 pm »
Quote
This is contrary what you say. You describe above, when you let the feature ENABLED, then it works.


That's not what I said.

Quote
As soon as this option is set to YES, the behaviour of the popup is going wrong as I tried to describe im my posts.

Thats what I told you. (I should have said: It is not working) And I mean the popup

So whats the difference between ENABLED and YES?

I'm not talking about disabling the system language filter plugin but enabling the new option which you can see in the attached pic. This is a complete new feature which was implemented into Joomla 2.5 between version 2.5.2 and 2.5.4. And when enabling this option all sites in VM, all sites from any compatible component with Joomla 2.5 work fine except the popup "add to cart".

So, to say it in your words: I have now ABS (VM popup), but it is working only properly when I turn out the light (disabling the option).

You may check it here (The option is enabled) Just put something in the cart.

http://www.panmusic.ch/virtuemart/en/shop/testkategorie/testproduct-detail

[attachment cleanup by admin]