News:

Support the VirtueMart project and become a member

Main Menu

COM_VIRTUEMART_SEARCH_ORDER_MANUFACTURER shows

Started by steveshop, December 30, 2011, 21:39:05 PM

Previous topic - Next topic

steveshop

Hi,

COM_VIRTUEMART_SEARCH_ORDER_MANUFACTURER

Shows in 'Sort by' field. There have been two prior questions on this previously back in November 2011 but gone unanswered:

http://forum.virtuemart.net/index.php?topic=93723.msg307786#msg307786

http://forum.virtuemart.net/index.php?topic=92720.msg304984#msg304984

Is there any VirtueMart dev out there who can help with this or, anyone know how to fix? I looked in /language/en-GB/en-GB.com_virtuemart.ini and the database using SQL query and can't even find the phrase 'COM_VIRTUEMART_SEARCH_ORDER_MANUFACTURER' - doesn't turn up anywhere I look, but must be somewhere obviously. Finding it is one thing, fixing is another. I Googled the phrase and other sites also have this bug:

http://www.jeanagdancewear.com/index.php/shop/by,manufacturer/desc/tops

http://pitbon.com/index.php/by,manufacturer/powertools/outdoortools

http://www.linelab.org/virtuemart-templates/index.php/virtuemart-2-example/by,manufacturer/sparkling-wines/champagnes?type=raw&limitstart=0

http://www.cyfordtechnologies.com/index.php/component/virtuemart/by,manufacturer/10/virtual-machines-equipment

http://scott.x1.ie/shop/index.php/en/component/virtuemart/by,manufacturer/vodafone

and that's just the first page of Google typing in the phrase, so a common problem. I didn't go through the other ten pages :)  ..anyone out there with an answer to this?

Many thanks,
Steve.

Milbo

Thank you for posting this many pages, they will like the backlink ;-)

It is a strange problem, you maybe noticed that when you choose something different the text is translated again. We will take a look on that, but we decided to handle it as a minor.
Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

steveshop

Thanks, Milbo - it's appreciated. I do appreciate and love all the work put into VirtueMart by yourself and the team. It is by far the best around off-the-shelf and a great system with great code behind it.

However, this still leaves me with two problems. The first you may be able to answer relatively quickly and that is where do I find the phrase 'COM_VIRTUEMART-SEARCH_ORDER_MANUFACTURER' in the files or MySQL database? - PHP admin I looked, not there (maybe) in MySQL and I also used Notepad+ to do a thorough search in the site files and can't find it. Would you know where it lives? If so, then I may be able to change this without breaking the code hopefully.

The other thing is I don't want it appearing (I have the latest VirtueMart btw, 2.0) and won't open the shop until I (or someone can help) fix this. It's not a good site experience for shoppers and visitors - vis-à-vis if people see that visiting the site in the 'Sort by' - it gives the impression 'hey, this site owner/shop doesn't even know how to fix their own code nor care, it's bugged, so how can I trust them when I buy?' - Which is what I would be thinking seeing that so presuming others will too. I would like to open the shop (offline until everything is hunky dory) as soon as possible and have third party vendors on site also involved who also would not be impressed. Further and needless to say perhaps, they may even not be interested continuing with us seeing an error like this as gives a bad impression for them as well. So, any fix or able to point to a possible/theoretical fix to at least get me started trying to work a fix myself asap is appreciated.

jjk

#3
I'm surprised how many VM2 shops are already online if I search for that key - I definitely fell behind with bringing my own VM2 shop online.  ;D

The funny thing is that if I use Firebug script view to look at a VM2 shop view which displays that key in the frontend and then type the key into the Firebug search, it stops and highlights at a line which is generated by the following lines from ...administrator\components\com_virtuemart\models\product.php:
$orderByList ='<div class="orderlistcontainer"><div class="title">'.JText::_('COM_VIRTUEMART_ORDERBY').'</div><div class="activeOrder"><a title="'.$orderTxt.'" href="'.$link.'">'.JText::_('COM_VIRTUEMART_SEARCH_ORDER_'.$orderby).' '.$orderTxt.'</a></div>';
$orderByList .= $orderByLink.'</div>';

$manuList ='';
if(VmConfig::get('show_manufacturers')){
if (empty ($currentManufacturerLink) ) $currentManufacturerLink = '<div class="title">'.JText::_('COM_VIRTUEMART_PRODUCT_DETAILS_MANUFACTURER_LBL').'</div><div class="activeOrder">'.JText::_('COM_VIRTUEMART_SEARCH_SELECT_MANUFACTURER').'</div>';
$manuList =' <div class="orderlistcontainer">'.$currentManufacturerLink;
$manuList .= $manufacturerLink.'</div><div class="clear"></div>';


...fortunately I don't seem to have this problem (screenshot below)

[attachment cleanup by admin]
Non-English Shops: Are your language files up to date?
http://virtuemart.net/community/translations

Studio 42

Sorry guys i don't understand the exact problem ?

http://forum.virtuemart.net/index.php?topic=93723.msg307786#msg307786
if you have no search order string, this is because the config is not set right

http://forum.virtuemart.net/index.php?topic=92720.msg304984#msg304984
simply add  in the language file
COM_VIRTUEMART_SEARCH_ORDER_MANUFACTURER
it's strange because in language file, we have
COM_VIRTUEMART_SEARCH_ORDER_MF_NAME
is this not right ?

Milbo

I think we use in the list and for the selected one a different lang tag, because when you choose it from the list it is there,..
Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

jjk

Just a note: I can't reproduce that problem. In my case the correct string is always there - in both installed languages. I don't have to select an option in order to see i.e the "sort by manufacturer" string.
Non-English Shops: Are your language files up to date?
http://virtuemart.net/community/translations

jjk

Quote from: Electrocity on December 31, 2011, 18:11:40 PM
it's strange because in language file, we have
COM_VIRTUEMART_SEARCH_ORDER_MF_NAME
is this not right ?

The 'Sort by' "Manufacturer name" in the drop-down list is coming from the key/string
COM_VIRTUEMART_MF_NAME="Manufacturer name"
not from
COM_VIRTUEMART_SEARCH_ORDER_MF_NAME="Manufacturer Name"

(I can see that because it's working for me, so I can also see the different case in name/Name)

Non-English Shops: Are your language files up to date?
http://virtuemart.net/community/translations

steveshop

Quote from: Electrocity on December 31, 2011, 18:11:40 PM
Sorry guys i don't understand the exact problem ?

http://forum.virtuemart.net/index.php?topic=93723.msg307786#msg307786
if you have no search order string, this is because the config is not set right

http://forum.virtuemart.net/index.php?topic=92720.msg304984#msg304984
simply add  in the language file
COM_VIRTUEMART_SEARCH_ORDER_MANUFACTURER
it's strange because in language file, we have
COM_VIRTUEMART_SEARCH_ORDER_MF_NAME
is this not right ?

A big THANK YOU!! to Electrocity, *Totally nailed it* - and so easy, simple. Adding 'COM_VIRTUEMART_SEARCH_ORDER_MANUFACTURER' in the en-GB.com_virtuemart.ini file worked and successfully changed to the term I wanted to use showing at the front end, which was 'By maker' (as opposed to By Manufacturer - COM_VIRTUEMART_SEARCH_ORDER_MANUFACTURER="By Maker") and 'COM_VIRTUEMART_SEARCH_ORDER_MANUFACTURER no longer shows :)

@ Milbo & jjk, yes COM_VIRTUEMART_SEARCH_ORDER_MF_NAME is there, however like said 'COM_VIRTUEMART_SEARCH_ORDER_MANUFACTURER' I still can't find anywhere, I had a look using Firebug too but going through all site files using Notepad++ has never failed for me before (and it is not in languages en ini). I suppose there's a first for everything though! Thanks once again guys and will I be plugging VirtueMart to all my friends and devs! 10/10 - GREAT WORK! Thanks for the support and HaPpY NeW YeAr! (yes, even code monkeys work on new year, never a rest for the wicked).

Cheers,

- Steve