Few bugs found in VM 3.4.0.9935

[man.of.earth]

Hello developers,

I found a few bugs in this version. I'm running Joomla 3.8.12.

1. /administrator/components/com_virtuemart/models/userfields.php
line 1119

Code Select Expand

$_return['fields'][$_fld->name]['formcode'] = JHTML::_('select.genericlist', $_values, $_prefix.$_fld->name.'_field', $_attribs, 'fieldvalue', 'fieldtitle', $_selected);
- added

Code Select Expand

.'_field'
after

Code Select Expand

$_prefix.$_fld->name
otherwise it did not validate HTML5 (mismatch with 'for' attribute)

line 1132

Code Select Expand

$_return['fields'][$_fld->name]['formcode'] =  JHtml::_('select.radiolist', $_values, $_prefix.$_fld->name.'_field', $_attribs, 'fieldvalue', 'fieldtitle', $_selected);

- added

Code Select Expand

.'_field'
after

Code Select Expand

$_prefix.$_fld->name
otherwise it did not validate HTML5 (mismatch with 'for' attribute)

2. in /administrator/components/com_virtuemart/views/user/tmpl/edit_shopper.php (line 294):

Code Select Expand

<img src="/images/stories/<?php echo $this->contactDetails->image; ?>" align="middle" alt="Contact" />
should not have /image/stories/ as path prefix but only a slash (otherwise the image is not rendered), so it should be

Code Select Expand

<img src="/<?php echo $this->contactDetails->image; ?>" align="middle" alt="Contact" />


George
https://www.proxima-mundi.ro