Author Topic: [BUG][Custom Fields] Cannot edit the price of custom field type  (Read 767 times)

thelordofweb

  • Guest
Summary
It is not possible to edit the price of a custom field when it already has a value higher than zero.

Testing Instructions
  • Create a custom field for a product.
  • Enter an amount for Price and save.
  • Try to edit this price to 0 or blank field.
VirtueMart and Joomla! versions
I use VirtueMart 3.0.16 and Joomla! 3.5.1

Milbo

  • Virtuemart Projectleader
  • Administrator
  • Super Hero
  • *
  • Posts: 9853
  • VM3.2 Cached and Optimized
    • VM3 Extensions
  • VirtueMart Version: VirtueMart 3 on joomla 3
Re: [BUG][Custom Fields] Cannot edit the price of custom field type
« Reply #1 on: May 30, 2016, 10:55:52 am »
Use "0.0", this counts for all prices
I should fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

thelordofweb

  • Guest
Re: [BUG][Custom Fields] Cannot edit the price of custom field type
« Reply #2 on: May 30, 2016, 11:46:13 am »
The value 0.0 works. Thank you!
I did a patch. I am attaching it as an archive with two files.
This patch makes it to be possible to edit the Price to 0 leaving the field blank or entering 0.

administrator/components/com_virtuemart/tables/product_customfields.php

patch_fix_customfields_price.diff

The second one is a file generated by Git. If you would like, you can use it to patch the file in your SVN.
I have never tried to patch SVN files with Git diff. However, if it works, people that use Git will be able to send you patches in this way.


Milbo

  • Virtuemart Projectleader
  • Administrator
  • Super Hero
  • *
  • Posts: 9853
  • VM3.2 Cached and Optimized
    • VM3 Extensions
  • VirtueMart Version: VirtueMart 3 on joomla 3
Re: [BUG][Custom Fields] Cannot edit the price of custom field type
« Reply #3 on: May 31, 2016, 19:23:42 pm »
I tell all the time, when people come up with the svn git stuff, that GIT patches WORK on SVN !

I take your patch, slightly changed.
I should fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

thelordofweb

  • Guest
Re: [BUG][Custom Fields] Cannot edit the price of custom field type
« Reply #4 on: May 31, 2016, 19:44:02 pm »
I see. :)
Thank you!