News:

Looking for documentation? Take a look on our wiki

Main Menu

Possible disadvantages of development

Started by vasena, October 16, 2013, 08:51:33 AM

Previous topic - Next topic

vasena

During development patterns I have find a few disadvantages:
1. When a product have no image, you can not set reference parameters
(line 478, file mediahandler.php)
Must be replaced:
return $ this-> displayIt ($ file_url, $ file_alt, $ imageArgs, $ lightbox);
with:
return $ this-> displayIt ($ file_url, $ file_alt, $ imageArgs, $ lightbox, $ effect);
2. If you re-use vmelements in the module settings, the element is not only a list of caches but also the value
(line 737, file shopfunctions.php)
Most likely you need to cache along with the selected value
PS line numbers is taken from the documentation for version 2.0.16

Milbo

Please explain further, and from where comes $effect?
Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

vasena


Milbo

I added it. Maybe people scream now, because the standard effect is now always set.
Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/