Code contribution: Small improvements in view / user / login

Started by rvbgnu, December 11, 2012, 19:22:17 PM

Previous topic - Next topic

rvbgnu

Hi,

I am not a DEV team member, but still want to contribute sometimes, even if I am busy with my clients projects (and happy about it ;-). I did not find how to do it simply, so I am just submitting here the file
components/com_virtuemart/views/user/tmpl/login.php (from the latest version 2.0.15b)
There is minor tweaks that I came across while developing for my clients.

Sorry if it the wrong place for that. Please feel free to redirect me to the right place.

Kind regards,
Hervé

[attachment cleanup by admin]
Best Regards, Hervé Boinnard - Irish Time (GMT)
Joomla! multilingual website and online business made easy - https://www.puma-it.ie

3D Secure v1 (3DS1) & Strong Customer Authentication (SCA)! Stripe.com payment plugin for VirtueMart 3: https://www.puma-it.ie/en/joomla-and-virtuemart-extensions/stripe-for-virtuemart
Authipay (AIB Merchant Services) for VirtueMart 2 & 3: https://www.puma-it.ie/en/joomla-and-virtuemart-extensions/authipay-aib-merchant-services-for-virtuemart

Milbo

looks like this should avoid the bug, that people are logged in via vm, but joomla is not correctly recognising it?
You added this <form id="com-form-login", I wonder if it interferes if you have the normal joomla login module enabled.
Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

rvbgnu

I don't know if it interferes, no tested actually.
But what I did is to strip the normal Joomla login, with just a template override of
modules/mod_login/tmpl/default.php

that I put into
templates/MY_TEMPLATE_NAME/html/mod_login/default.php

Around line 73:
<a href="<?php echo JRoute::_('index.php?option=com_virtuemart&view=user&layout=edit'); // XXX WAS index.php?option=com_users&view=registration ?>">

So that the Joomla registration, without any billing address, is not directly accessible.

On the eCommerce website with hundreds of people per day, I never had an issue reported like "people are logged in via vm, but joomla is not correctly recognising it".
I have one with the registration link not working sometimes, and I am investigating it at present.

Let me know if I can be of any further help.
Best Regards, Hervé Boinnard - Irish Time (GMT)
Joomla! multilingual website and online business made easy - https://www.puma-it.ie

3D Secure v1 (3DS1) & Strong Customer Authentication (SCA)! Stripe.com payment plugin for VirtueMart 3: https://www.puma-it.ie/en/joomla-and-virtuemart-extensions/stripe-for-virtuemart
Authipay (AIB Merchant Services) for VirtueMart 2 & 3: https://www.puma-it.ie/en/joomla-and-virtuemart-extensions/authipay-aib-merchant-services-for-virtuemart

Milbo

Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

rvbgnu

You're more than welcome Max!

And congratulations to you and Dev team, especially for the hard work implementing MVC and the Joomla template override! VM2 is so great with this!

Kind regards
Best Regards, Hervé Boinnard - Irish Time (GMT)
Joomla! multilingual website and online business made easy - https://www.puma-it.ie

3D Secure v1 (3DS1) & Strong Customer Authentication (SCA)! Stripe.com payment plugin for VirtueMart 3: https://www.puma-it.ie/en/joomla-and-virtuemart-extensions/stripe-for-virtuemart
Authipay (AIB Merchant Services) for VirtueMart 2 & 3: https://www.puma-it.ie/en/joomla-and-virtuemart-extensions/authipay-aib-merchant-services-for-virtuemart

Milbo

Thank you. Do you know that you can even overwrite most virtuemart plugins ? (if they are written that way)
Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/

rvbgnu

No, I did not, that sounds good too! But what kind of plugin overwrite do you think?
Shipment (not sure if need it, prefer to enhance the default one)?
Custom? Maybe for custom fields and child variants. I struggled with them last May and June, and ended up with the Drop plugin from BanquetTablePro.

Any example to point me to, please?
Best Regards, Hervé Boinnard - Irish Time (GMT)
Joomla! multilingual website and online business made easy - https://www.puma-it.ie

3D Secure v1 (3DS1) & Strong Customer Authentication (SCA)! Stripe.com payment plugin for VirtueMart 3: https://www.puma-it.ie/en/joomla-and-virtuemart-extensions/stripe-for-virtuemart
Authipay (AIB Merchant Services) for VirtueMart 2 & 3: https://www.puma-it.ie/en/joomla-and-virtuemart-extensions/authipay-aib-merchant-services-for-virtuemart