Reload previously stored cart after login doesn't work properly

[Dudebaker]

The previously stored cart gets only reloaded from the database if the user is on the cart page while he does the login.
If he's on any other page as the cart page, the cart stays empty.

How to reproduce the bug:
1. Install Virtuemart Demo-Installation
2. Create a registered user
3. Add something to the cart and go to the cart (otherwise it will not be saved to the DB, that's another bug I think).
4. Logout
5. Go to the Homepage
6. Login --> no cart loaded in the cart module
7. Logout
8. Go to the Cart-Page
9. Login --> cart loaded in the cart module

I've tested this with the latest Demo-Installation (VirtueMart3.8.8_Joomla_3.9.24-Stable-Full_Package.zip) and even the later beta builds.
Sadly always the same bug.

How to fix the bug (quick and dirty but it does work):
- components/com_virtuemart/helpers/cart.php[line 222]
- change

Code Select Expand

if(empty(JFactory::getUser()->guest) and !empty($sessionCart->_guest)){
- to

Code Select Expand

if(empty(JFactory::getUser()->guest) and (!empty($sessionCart->_guest) || empty(self::$_cart->BT))){


As I saw some lines above this, there is already something a dev has tried [line 169]:

Code Select Expand

//if(empty($sessionCart->cartProductsData) or ($sessionCart->_guest and $sessionCart->_guest!=JFactory::getUser()->guest)){
I think this goes in the same direction to fix this issue, but wasn't finished


PS:
If you're using a Cart-Module which uses the function cart->prepareCartData() then the cart always gets loaded properly on every page after login where the module is visible.
The one I'm usually using from Virtueplanet does this, but on one customer-shop I have to hide it till the user is logged in (only registered access level).
And in this instance I've noticed the bug and testet it with the Virtuemart-Demo Package.

[Milbo]

Thank you for this report. I found a good fix.

[Milbo]

Please test https://dev.virtuemart.net/attachments/1291/com_virtuemart.3.8.9.10557_package_or_extract.zip

[Dudebaker]

Thanks but now the cart keeps being empty after login, even on the cart page.

I think the line (the same as I did) you've changed is not corret.

Change:

Code Select Expand

if(VmConfig::isSite() and JFactory::getUser()->guest and (empty($sessionCart) or !empty($sessionCart->_guest)) ){
To:

Code Select Expand

if(VmConfig::isSite() and empty(JFactory::getUser()->guest) and (empty($sessionCart) or !empty($sessionCart->_guest)) ){

And the cart loads correct again on every page.

[Milbo]

of course yes. I accidently removed the empty, when I added the check for site.