"Comma allergy", blocking categories and inconsistency

[gba]

Hi VM community!

I am working with VM 3.0.12, Revision 9058.
During testing some things grabed my attention, and maybe this is also of interest for you:

1) I noticed, that some value fields in the payment/shipment plugins seem to be "allergic" against a comma (,) as decimal separator in German configurations.
Examples:
- In payment plugin 'standard' the field 'Fee per transaction'.
- In shipment plugin 'weight_country' the field 'Shipment Cost'.
Using comma as separator in these fields the value is saved properly, but in calculations the decimal part is ignored.

2) In the shipment plugin 'weight_countries' something "interesting" is happening, when I choose one or more categories for a shipment method:
After saving the shipment method, all chosen categories are also displayed in the 'Blocking categories' field. Actually it seems, as if the blocking categories were not considered in calculations in this case, though.
So no problem for the shop, just "interesting" 

3) I also noticed, that the payment plugins shipped with VM seem to not render payment information into object property orderDetails['paymentName'] consistently:
i.e. SOFORT plugin renders its information using DIVs, while the standard plugin does not.
This makes layouting of emails difficult.

4) Also the response page layouts of the payment plugins are generated in a very various way, what makes templating quite a challenge.
Of course it is up to the programmers of third party plugins to follow consistency. But it would be great, when the plugins included in VM would have consistent outputs.

Can anyone confirm these observations?
Maybe I overlooked some configuration mistake I made...
I am looking forward to your feedback!

Kind regards,
Gerald

[GJC Web Design]

1) I noticed, that some value fields in the payment/shipment plugins seem to be "allergic" against a comma (,) as decimal separator in German configurations.

For coding consistency should a comma ever be allowed as a decimal separator?

[gba]

Hi!

Thank you for your quick reply!

For coding consistency should a comma ever be allowed as a decimal separator?

As the VM backend seems not to be intended for coders, only, but mainly for non programmers, I would say, local decimal separators should work for shop owners.
Alternatively there should be the point (.) as decimal separator consistently, also in i.e. the products list.
Meanwhile I noticed, indeed, that value fields seem to use the point (.) as decimal separator generally in VM. So it IS kind of consistent, maybe just irritating for non programmers, when i.e. the calculated product price is listed with comma (,) in the products list.

What about the other points?

Kind regards,
Gerald

[Troels_E]

Joomla 3.4.8
VM 3.0.12

I can confirm the blocking categories issue here, don't know if this was an issue prior to 3.012 as we didn't use blocking before.
Even if I delete the blocking categories and save they reappear.
As said, they don't influence on the frontend.

Comma should be allowed as it is the seperator here and I wouldn't really consider it localized if commas wasn't allowed.

[gba]

Hi!

Did I overread the issues of this thread being fixed in current VM 3.0.18 or are they still open?

Kind regards,
Gerald

EDIT: Point 2) seems to be fixed.