VirtueMart Forum

VirtueMart 2 + 3 + 4 => Templating & Layouts => Topic started by: 2cool on June 20, 2017, 00:48:33 AM

Title: Sale category price issue
Post by: 2cool on June 20, 2017, 00:48:33 AM
Hi,
I created a sale category and added a 25% discount in tax.
All works except for price display.

I want normal price €100 and sale price €75 ?
Now it shows: You save: €25 without vat.

Is this possible and where should this be set (template override? prices.php?)

Thanks and regards,

Pas

Joomla 3.7.2 VirtueMart 3.2.2
Title: Re: Sale category price issue
Post by: K&K media production on June 20, 2017, 00:59:20 AM
QuoteNow it shows: You save: €25 without vat.

Should be a override from your commercial template


QuoteI want normal price €100 and sale price €75

This is the normal way how vm shows discounts. Disable your active commercial template overrides or try protostar.
Title: Re: Sale category price issue
Post by: 2cool on June 20, 2017, 09:36:04 AM
Thanks,
What file could be overriden, so I can remove this to test?
Maybe there is something wrong in my settings because it is showing 'you save' -xx

This is what I use:
product price
sale (set in vat)
category using 'sale' to calculate discount.

Not sure if this is done right....

Thanks and regards,
Pas
Title: Re: Sale category price issue
Post by: Jörgen on June 20, 2017, 10:06:26 AM
Quote from: 2cool on June 20, 2017, 00:48:33 AM
Now it shows: You save: €25 without vat.

This is a setting in Your template. Check the template settings. What template Do You use ?

Jörgen @ Kreativ Fotografi
Title: Re: Sale category price issue
Post by: Ghost on June 20, 2017, 13:01:48 PM
Try unchecking 'Discount amount' in VM Configuration -> Pricing.
Title: Re: Sale category price issue
Post by: 2cool on June 20, 2017, 13:19:25 PM
Hi,
I use regular and b2b group with different tax settings.
regular 'vat tax per product'
b2b is set as 'tax per bill'

the price settings are also right (discount 25% is done)
but the price and discount price don't show for b2b?

Looks like some setting problem or bug?

Maybe someone have been pulling his hair on this before ;)

Thanks,
Pas
Title: Re: Sale category price issue
Post by: Jörgen on June 20, 2017, 13:27:04 PM
Is this the same question or a new one, please start a new thread if so.

The winkeliers price has overwrite final, untick.

Jörgen @ Kreativ Fotografi
Title: Re: Sale category price issue
Post by: 2cool on June 20, 2017, 14:07:02 PM
Thanks,
Changed this for testing but doesn't solve the problem.
Attached the price settings for the b2b (winkeliers) group, maybe this is wrong?

Regards,
Pas
Title: Re: Sale category price issue
Post by: K&K media production on June 20, 2017, 19:00:41 PM
Quotethe price settings are also right (discount 25% is done)
but the price and discount price don't show for b2b?

If you have different prices, you have no discounts! And you have a override price of 0!

-> delete the second price, there should be only one price
-> set VatTax rules to "Apply generic rules"

-> apply your calculation rules (VatTax and discounts) to your shoppergroups

Read the documentation
https://docs.virtuemart.net/tutorials/administration-configuration-vm-2/109-taxes-calculation-rules-case-1.html


Quote
Now it shows: You save: €25 without vat.

Should be a override from your commercial template



I want normal price €100 and sale price €75

This is the normal way how vm shows discounts. Disable your active commercial template overrides or try protostar.




Title: Re: Sale category price issue
Post by: 2cool on June 20, 2017, 19:49:31 PM
thanks, but prices are right.
1 for regular shoppers
2 for b2b shoppers

I want to config and set discounts for both groups.

regular works and shows prices with the discount.
b2b doesn't work, only shows discounted price.

b2b shows all prices without tax. Tax & Calculation Rule is set as 'tax per bill'

Hope this explains a bit better.
Thanks and regards,
Pas
Title: Re: Sale category price issue
Post by: Jörgen on June 20, 2017, 20:45:49 PM
You don´t see any tax before the total is calculated in the cart and only as total if you set tax per bill

Jörgen @ Kreativ Fotografi
Title: Re: Sale category price issue
Post by: 2cool on June 20, 2017, 22:28:55 PM
thanks, but that's not what I want.

I want to see normal price and 'discount price' together, without tax for b2b, where tax is calculated in the cart.

for regular shoppers it's different and already working;
these prices are displayed with tax, and discount is calculated perfect.

Thanks,
Pas
Title: Re: Sale category price issue
Post by: 2cool on June 23, 2017, 20:23:52 PM
I still can't figure out what's wrong here...hope someone can tell me how to solve.
Attached the settings for shop prices, taxes, shoppers.
Need to get the price + discount price for B2B in sale categroy (prices without tax)

Thanks,
Pas
Title: Re: Sale category price issue
Post by: Jörgen on June 23, 2017, 20:50:58 PM
You have added B2BTax for B2B in the product, should not be used if You don´t want B2B to be taxed. Why do You have the 21 % tax for B2B if You don´t want to tax them ? This rule will be effective for B2B even when you don´t have it assigned to the product. Ypu can imit the use with product categories, user groups etc. Otherwise it applies to all.

Jörgen @Kreativ Fotografi
Title: Re: Sale category price issue
Post by: 2cool on June 23, 2017, 21:52:51 PM
Hi Jörgen,
I'm confused, b2b should be taxed but is set as TaxBill. So prices shown are without tax but will be displayed/added in cart/bill.

I find this very hard to configure with so many settings.....

Do you also use 2 groups as explained?


Thanks,
Pas
Title: Re: Sale category price issue
Post by: Jörgen on June 23, 2017, 23:52:22 PM
Ok I mixed your price settings.
How does it look? Very hard to guess what you are seeing as a result in product view and cart view.
Jörgen @ Kreativ Fotografi
Title: Re: Sale category price issue
Post by: 2cool on June 24, 2017, 13:55:21 PM
Hi Jörgen,

I've been testing all kinds of settings on local backup.
For private customers it displays right; regular price  + discount price (both incl. tax)
The B2B group doesn't show both?

Can't find any clear info on how to configure these settings for 2 shopper groups...

Hope someone can point me in the right direction.

Thanks,
Pas
Title: Re: Sale category price issue
Post by: K&K media production on June 24, 2017, 14:57:59 PM
you can't display a product price with tax if there is only a tax per bill rule

if you want something like this, you must build your own php functions to calculate such a price
Title: Re: Sale category price issue
Post by: 2cool on June 24, 2017, 16:11:44 PM
Hi k&k,

There are 2 shopper groups, both have their own tax/vat settings
Every product has 2 prices, b2b and private shoppers.

private shoppers see prices with tax
b2b see prices without tax (tax per bill)

Guess this should be a pretty basic setup....

Now I need to add a sale category for both groups but can't figure out why this is so difficult to configure.

If anyone can tell me how to configure this?

Regards,
Pas
Title: Re: Sale category price issue
Post by: 2cool on June 26, 2017, 08:36:40 AM
Hi there,
Did some more testing and noticed the price and discount price is displayed in cart for B2B shoppers??
Now I only need this to be displayed on products too..

See attached screens with settings.

Thanks,
Pas
Title: Re: Sale category price issue
Post by: 2cool on July 04, 2017, 21:57:28 PM
Still unsolved....I did a clean install of joomla and virtuemart.
But with this setup still can't get the price settings right?

Attached details of private and b2b shoppers (product and card)
Also the product proce settings

I want b2b to show price discount the same as private price.

Hope anyone can tell me how to fix....

Regards,
Pas
Title: Re: Sale category price issue
Post by: 2cool on July 20, 2017, 01:13:57 AM
Did many tests and still not able to solve this issue.
Right now I can see the regular and discount price are displayed in the cart for b2b shoppers ???

Why can't this be on product page...

Hope someone has a solution for this.
Attached the settings for b2b shopper group and product.

Regards,
Pas
Title: Re: Sale category price issue
Post by: K&K media production on July 20, 2017, 13:04:24 PM
The crossed price is the base price incl. vat tax. Your b2b products have no vat tax -> there is no price incl. vat tax.

You must modify your template. Look how the output for the b2c crossed price is done and add something for your b2b prices.
Title: Re: Sale category price issue
Post by: 2cool on July 27, 2017, 13:34:49 PM
Hi thanks for your reply,

I feel stupid, why isn't this 'standard' as this (Overwrite final) is a standard option to use in product price.

And in what file should I find the b2b crossed price?
What file should be modified to show this price on product pages?

Thanks and regards,
Pas
Title: Re: Sale category price issue
Post by: 2cool on July 29, 2017, 00:39:06 AM
Looking in 'prices.php' my guess is where I should add the overwrite final for b2b.
But I just don't see or know how to find this variable or add this for the b2b customers....

Hope anyone can explain if this is the right move.

Regards,
Pas


<?php
/**
 *
 * Show the product prices
 *
 * @package    VirtueMart
 * @subpackage
 * @author Max Milbers, Valerie Isaksen
 * @link ${PHING.VM.MAINTAINERURL}
 * @copyright Copyright (c) 2004 - 2014 VirtueMart Team. All rights reserved.
 * @license http://www.gnu.org/copyleft/gpl.html GNU/GPL, see LICENSE.php
 * VirtueMart is free software. This version may have been modified pursuant
 * to the GNU General Public License, and as distributed it includes or
 * is derivative of works licensed under the GNU General Public License or
 * other free or open source software licenses.
 * @version $Id: default_showprices.php 8024 2014-06-12 15:08:59Z Milbo $
 */
// Check to ensure this file is included in Joomla!
defined ('_JEXEC') or die('Restricted access');
$product $viewData['product'];
$currency $viewData['currency'];

?>

<div class="product-price" id="productPrice<?php echo $product->virtuemart_product_id ?>">
<?php
if (!empty(
$product->prices['salesPrice'])) {
//echo '<div class="vm-cart-price">' . vmText::_ ('COM_VIRTUEMART_CART_PRICE') . '</div>';
}

if ($product->prices['salesPrice']<=and VmConfig::get ('askprice'1) and isset($product->images[0]) and !$product->images[0]->file_is_downloadable) {
$askquestion_url JRoute::_('index.php?option=com_virtuemart&view=productdetails&task=askquestion&virtuemart_product_id=' $product->virtuemart_product_id '&virtuemart_category_id=' $product->virtuemart_category_id '&tmpl=component'FALSE);
?>

<a class="ask-a-question bold" href="<?php echo $askquestion_url ?>" rel="nofollow" ><?php echo vmText::('COM_VIRTUEMART_PRODUCT_ASKPRICE'?></a>
<?php
} else {
//if ($showBasePrice) {
echo $currency->createPriceDiv ('basePrice''COM_VIRTUEMART_PRODUCT_BASEPRICE'$product->prices);
//if (round($product->prices['basePrice'],$currency->_priceConfig['basePriceVariant'][1]) != $product->prices['basePriceVariant']) {
echo $currency->createPriceDiv ('basePriceVariant''COM_VIRTUEMART_PRODUCT_BASEPRICE_VARIANT'$product->prices);
//}

//}
echo $currency->createPriceDiv ('variantModification''COM_VIRTUEMART_PRODUCT_VARIANT_MOD'$product->prices);
if (round($product->prices['basePriceWithTax'],$currency->_priceConfig['salesPrice'][1]) != round($product->prices['salesPrice'],$currency->_priceConfig['salesPrice'][1])) {
echo '<span class="price-crossed" >' $currency->createPriceDiv ('basePriceWithTax''COM_VIRTUEMART_PRODUCT_BASEPRICE_WITHTAX'$product->prices) . "</span>";
}
if (round($product->prices['salesPriceWithDiscount'],$currency->_priceConfig['salesPrice'][1]) != round($product->prices['salesPrice'],$currency->_priceConfig['salesPrice'][1])) {
echo $currency->createPriceDiv ('salesPriceWithDiscount''COM_VIRTUEMART_PRODUCT_SALESPRICE_WITH_DISCOUNT'$product->prices);
}

echo $currency->createPriceDiv ('salesPrice''COM_VIRTUEMART_PRODUCT_SALESPRICE'$product->prices);
echo $currency->createPriceDiv ('salesPriceTt''COM_VIRTUEMART_PRODUCT_SALESPRICE_TT'$product->prices);
//echo $currency->createPriceDiv ('salesPrice', 'COM_VIRTUEMART_PRODUCT_SALESPRICE', $product->prices);
//echo $currency->createPriceDiv ('salesPriceQu', 'COM_VIRTUEMART_PRODUCT_SALESPRICE', $product->prices);
if ($product->prices['discountedPriceWithoutTax'] != $product->prices['priceWithoutTax']) {
echo $currency->createPriceDiv ('discountedPriceWithoutTax''COM_VIRTUEMART_PRODUCT_SALESPRICE_WITHOUT_TAX'$product->prices);
echo $currency->createPriceDiv ('discountedPriceWithoutTaxTt''COM_VIRTUEMART_PRODUCT_SALESPRICE_WITHOUT_TAX_TT'$product->prices);
} else {
echo $currency->createPriceDiv ('priceWithoutTax''COM_VIRTUEMART_PRODUCT_SALESPRICE_WITHOUT_TAX'$product->prices);
echo $currency->createPriceDiv ('priceWithoutTaxTt''COM_VIRTUEMART_PRODUCT_SALESPRICE_WITHOUT_TAX_TT'$product->prices);
}
  echo 
$currency->createPriceDiv ('discountAmount''COM_VIRTUEMART_PRODUCT_DISCOUNT_AMOUNT'$product->prices);
echo $currency->createPriceDiv ('discountAmountTt''COM_VIRTUEMART_PRODUCT_DISCOUNT_AMOUNT_TT'$product->prices);
echo $currency->createPriceDiv ('taxAmount''COM_VIRTUEMART_PRODUCT_TAX_AMOUNT'$product->prices);
echo $currency->createPriceDiv ('taxAmountTt''COM_VIRTUEMART_PRODUCT_TAX_AMOUNT_TT'$product->prices);
$unitPriceDescription vmText::sprintf ('COM_VIRTUEMART_PRODUCT_UNITPRICE'vmText::_('COM_VIRTUEMART_UNIT_SYMBOL_'.$product->product_unit));
echo $currency->createPriceDiv ('unitPrice'$unitPriceDescription$product->prices);
}
?>

</div>

Title: Re: Sale category price issue
Post by: 2cool on August 07, 2017, 09:28:10 AM
Does anyone know what file should be modified to show base price and discount price without tax?
Need to add a simple sale category for b2c and b2b shoppers...

Thanks in advance,

Pas
Title: Re: Sale category price issue
Post by: 2cool on August 28, 2017, 11:13:30 AM
Hi,
Wonder if there's an option to get some help with vm customization.
Could anyone tell me how.
Is there some paid support to get this done?

Thanks and regards,
Pas
Title: Re: Sale category price issue
Post by: 2cool on September 27, 2017, 18:25:26 PM
After a month still no reply...
Aren't there any options to get support for some virtuemart customizations?

I'm not a programmer but need some help with some 'easy' changes;
- invoice layout
- product sale option

Been asking if this could be done with any of the support options:
http://extensions.virtuemart.net/support

Hope someone could tell me what options there are.

Thanks & regards,
Pas
Title: Re: Sale category price issue
Post by: K&K media production on September 27, 2017, 18:43:02 PM
Yes it's possible as commercial job. I'll send you a pm.