VirtueMart Forum

VirtueMart 2 + 3 + 4 => Virtuemart Development and bug reports => Topic started by: MAD King on March 22, 2015, 15:03:09 PM

Title: VM Products not working anymore after Joomla update
Post by: MAD King on March 22, 2015, 15:03:09 PM
After I updated Joomla to version 3.4.1, I am not able to Save & Close, Save, or Cancel products anymore. The buttons do not react.
I already reported this issue to Joomla and they guess is:

QuoteMy first bet is that they somehow rely on MooTools being loaded without loading it themself.


Joomla 3.4.1
Vm 3.0.6.2
Title: Re: VM Products not working anymore after Joomla update
Post by: MAD King on March 22, 2015, 19:31:22 PM
UPDATE: I restored it to Joomla 3.4.0 with VM  3.0.6.2 and the same issue. It is definitely Virtuemart.
Title: Re: VM Products not working anymore after Joomla update
Post by: lindapowers on March 22, 2015, 20:17:32 PM
Tested with

Joomla 3.4.1
Vm 3.0.6.2

Happens the same to me.

Regards
Title: Re: VM Products not working anymore after Joomla update
Post by: MAD King on March 22, 2015, 20:52:59 PM
Uff, I am glad I am not the only one.
Title: Re: VM Products not working anymore after Joomla update
Post by: Anirudh on March 22, 2015, 21:38:59 PM
same here!





Virtuemart 3.0.6.2
Joomla 3.4.1
Title: Re: VM Products not working anymore after Joomla update
Post by: Jormolca on March 22, 2015, 23:40:25 PM
Hi, I have the same problem:
Joomla 3.4.1
Virtuemart 3.0.6.2
Title: Re: VM Products not working anymore after Joomla update
Post by: jenkinhill on March 22, 2015, 23:42:59 PM
Works fine for me with new install of J3.4.0 but not with new install of J3.4.1 - the error has been identified but not the exact cause. There were more than a few code changes/fixes between J3.4 & J3.4.1. And issues starting to appear in the Joomla bug tracker. http://issues.joomla.org/tracker/joomla-cms
Title: Re: VM Products not working anymore after Joomla update
Post by: MAD King on March 22, 2015, 23:46:14 PM
Like I wrote in my previous post. It does also not work with Joomla 3.4 on my site, but it was also an update and not a fresh installation. So, there is something not right in the update too.
Title: Re: VM Products not working anymore after Joomla update
Post by: Anirudh on March 23, 2015, 02:10:06 AM
Quote from: jenkinhill on March 22, 2015, 23:42:59 PM
Works fine for me with new install of J3.4 but not with new install of J3.4.1 - the error has been identified but not the exact cause. There were more than a few code changes/fixes between J3.4 & J3.4.1. And issues starting to appear in the Joomla bug tracker. http://issues.joomla.org/tracker/joomla-cms

Do you mean that if I roll back to J 3.4, I will get the Save and Close button back to normal?
Title: Re: VM Products not working anymore after Joomla update
Post by: MAD King on March 23, 2015, 02:18:18 AM
No it will not. Tried it already.
Title: Re: VM Products not working anymore after Joomla update
Post by: Mike J on March 23, 2015, 05:47:29 AM
Same problem here :'( ... Any solutions?
Title: Re: VM Products not working anymore after Joomla update
Post by: jenkinhill on March 23, 2015, 11:26:07 AM
Quote from: Anirudh on March 23, 2015, 02:10:06 AM
Do you mean that if I roll back to J 3.4, I will get the Save and Close button back to normal?

A rollback from 3.4.1 to 3.4 does not work, but a fresh install of 3.4 worked OK for me. The devs are working on a solution.

If it were an issue with VM3.0.6.2 on J3.4 then the forum would have been inundated with reports already.
Title: Re: VM ПроSPAMукты больше не работает после обновления Joomla
Post by: gudrus on March 23, 2015, 12:37:17 PM
НаSPAMо жSPAMать пока разработчики исправят ошибку в Joomla и после этого сSPAMелать обновление?


При уSPAMалении крестиком в товаре с права

Цена товара (Вы нахоSPAMитесь в группе покупателей COM_VIRTUEMART_SHOPPERGROUP_DEFAULT)

все сохраняется но без цены соответственно!


When you delete a cross in from the right product

Commodity price (you're in a group of buyers COM_VIRTUEMART_SHOPPERGROUP_DEFAULT)

all retained but without the price accordingly!


VirtueMart 3.0.6.3
Joomla! версия, 3.4.1
Title: Re: VM Products not working anymore after Joomla update
Post by: Milbo on March 23, 2015, 16:17:06 PM
Quote from: MAD King on March 22, 2015, 19:31:22 PM
UPDATE: I restored it to Joomla 3.4.0 with VM  3.0.6.2 and the same issue. It is definitely Virtuemart.

You must of course delete your browser cache! Joomla does NOT send the current version as vm does. So you must delete the cache. Btw

http://forum.virtuemart.net/index.php?topic=128962.msg443567#msg443567

It seems the solution is to use j3.4.1 with the js of j3.4.0
Title: Re: VM Products not working anymore after Joomla update
Post by: Milbo on March 23, 2015, 16:19:30 PM
Quote from: gudrus on March 23, 2015, 12:37:17 PM
When you delete a cross in from the right product

Commodity price (you're in a group of buyers COM_VIRTUEMART_SHOPPERGROUP_DEFAULT)

all retained but without the price accordingly!

You mean, when you use the red cross to delete all products prices, then it works. Yes. The problem is the new validator, which cannot handle this multiple arrays,

So this input here
mprices[product_price_publish_up][]

throws this error
Error: Syntax error, unrecognized expression: #mprices[product_price_publish_up][]-lbl
Title: Re: VM Products not working anymore after Joomla update
Post by: MAD King on March 23, 2015, 16:30:08 PM
Funny, for me it read as VM is blaming Joomla, and on Joomla forum they blame VM.
Title: Re: VM Products not working anymore after Joomla update
Post by: lindapowers on March 23, 2015, 17:35:23 PM
I believe we cant just install the package for joomla 3.4.0 back so any help a bit more detailed about the process to solve this would be great.

Regards
Title: Re: VM Products not working anymore after Joomla update
Post by: deepsky303 on March 23, 2015, 18:08:37 PM
 It is definitely Virtuemart.
If you delete an updated virtuemart and put again the previous version it will work fine on any version of Joomla. But when updating to 3.0.6.2 again problems with the products.
Title: Re: VM Products not working anymore after Joomla update
Post by: lindapowers on March 23, 2015, 18:26:08 PM
The problem is not only with products but with multilingual stores, this combination of joomla 3.4.1 and vm 3.062 or 63 kills the languages in front end and links to additional languages in products creating 404 or non translated texts in frontend. Is easy to check in the backend when changing language in the shop section, only displays the default even when the rest is filled up and appears in the database.

The website itself except vm works well, even the languages in the non vm pages, not blaming vm though but hell... never though this update to j 3.4.1 would bring so much pain :(
Title: Re: VM Products not working anymore after Joomla update
Post by: Miku on March 23, 2015, 18:51:13 PM
Quote from: deepsky303 on March 23, 2015, 18:08:37 PM
It is definitely Virtuemart.
I'm far from giving such opinions but in my case is similarly - I mean I work on VM 3.0.6 and J! 3.4.1 and the issue you have mentioned about doesn't occur. So maybe in fact the devs of Virtuemart should look for the cause in their code not in Joomla...
Title: Re: VM Products not working anymore after Joomla update
Post by: franzpeter on March 23, 2015, 19:09:10 PM
The quickest solution for the moment to get it to work with Joomla 3.4.1  is to exchange two core files in Joomla. Login in with ftp to your Joomla installation. There is a folder called media/system/js. Inside there are two files: validate-uncompressed.js and validate.js. To keep those two files, just rename them with newvalidate-uncompressed.js and newvalidate.js. Take the two files from Joomla 3.4 and FTP those two files into the same folder as mentioned above. Should work again until a solution is found.
Title: Re: VM Products not working anymore after Joomla update
Post by: Miku on March 23, 2015, 19:20:15 PM
Quote from: franzpeter on March 23, 2015, 19:09:10 PM
The quickest solution for the moment to get it to work with Joomla 3.4.1  is to exchange two core files in Joomla. Login in with ftp to your Joomla installation.
What about the solution presented in this thread?
http://forum.virtuemart.net/index.php?topic=128961.msg443621#msg443621
Could be an alternative for the one you have mentioned?
Title: Re: VM Products not working anymore after Joomla update
Post by: franzpeter on March 23, 2015, 19:24:52 PM
Agree, that is the better solution!
;)
Title: Re: VM Products not working anymore after Joomla update
Post by: kaybee57 on March 24, 2015, 04:47:11 AM
Exactly the same issue here as well.
Tried all sorts of modifications with no luck.
Title: Re: VM Products not working anymore after Joomla update
Post by: Milbo on March 24, 2015, 10:17:44 AM
Quote from: Miku on March 23, 2015, 18:51:13 PM
Quote from: deepsky303 on March 23, 2015, 18:08:37 PM
It is definitely Virtuemart.
I'm far from giving such opinions but in my case is similarly - I mean I work on VM 3.0.6 and J! 3.4.1 and the issue you have mentioned about doesn't occur. So maybe in fact the devs of Virtuemart should look for the cause in their code not in Joomla...

The reason is, that we added the js validation for the product edit, which was not used before. The js validation works fine with j2.5.x and j3.3 and j3.4.0, but NOT with j3.4.1, so it is indeed a joomla problem.
Title: Re: VM Products not working anymore after Joomla update
Post by: Losth on March 24, 2015, 10:38:54 AM
Quote from: franzpeter on March 23, 2015, 19:09:10 PM
...is to exchange two core files in Joomla. validate-uncompressed.js and validate.js. Should work again until a solution is found.

Yeah, thanks. It works.
3.4.1+3.0.6.2

P.S. I had a clean and empty parallel system J3.4+3.0.6.2 updated with 3.4.1 = there were no probs with product's saving.
Title: Re: VM Products not working anymore after Joomla update
Post by: hakan26 on March 24, 2015, 12:00:58 PM
I renamed two files on FTP, still same issue.

How to fix?
Title: Re: VM Products not working anymore after Joomla update
Post by: Milbo on March 24, 2015, 12:36:53 PM
http://forum.virtuemart.net/index.php?topic=128961.msg443712#msg443712 here is the right fix
Title: Re: VM Products not working anymore after Joomla update
Post by: MAD King on March 24, 2015, 14:35:05 PM
Quote from: Milbo on March 24, 2015, 10:17:44 AM

................so it is indeed a joomla problem.

Nothing gets solved by blaming others. You have to work together to get a solution.
Title: Re: VM Products not working anymore after Joomla update
Post by: Milbo on March 24, 2015, 14:55:06 PM
MAD King it creates an error and before there was no error. They fixed something completly different and as side effect it breaks the js, if you use an id with []. The reason is that it was before escaped or something like that and now not anylonger.

I dont know why they did the changes, but assumingly to make the validation more restrictive, but not less robust.

In VM we talk about to add fallbacks if the developers did a real error. Joomla reacts more and more strict. In our case to use an id with [] in the name is valid and allowed, but not validating strictly for all doctypes. So for HTML5 it is valid, for HTML4.01 Strict it is invalid. None browser had problems with it the last years. It is just the new validation.js. From my point of view a devolution.

Code should always become more robust, except it is extraordinary slow. A good example here are the changed language files from j1.5 to j2.5. But here is no reason to break it. So we convert now the [] to dots and anything is fine.
Title: Re: VM Products not working anymore after Joomla update
Post by: Milbo on March 24, 2015, 15:00:29 PM
Quote from: MAD King on March 24, 2015, 14:35:05 PM
Quote from: Milbo on March 24, 2015, 10:17:44 AM

................so it is indeed a joomla problem.

Nothing gets solved by blaming others. You have to work together to get a solution.

and actually, no we do not work together and I found the solution with the help of a vm user. I am sure if you try to explain them, they wont change it. They will insist that it is anyway not clean to use such an id. Regardless if it is valid in html5, ohh, actually that could be a valid argument for them.
Title: Re: VM Products not working anymore after Joomla update
Post by: MAD King on March 24, 2015, 15:21:02 PM
Oh, thank you for the deeper explanation. I understand now, but do not understand why they change things which worked before. This makes it more difficult for third parties and their customers.
Title: Re: VM Products not working anymore after Joomla update
Post by: Milbo on March 24, 2015, 20:37:34 PM
I think there happened two different things, but I dont know for sure, I just guess.

On one hand they wanted to remove the use of mootools, which is good. and on the other hand I think they "enhanced" the validation. But somewhere there is a small error, maybe mootools escaped it automatically or so.

Fact is, if you write html5 valid html it is unlikely that you use [] for an id, but as you can see it can happen fast with generic fallbacks.
Title: Re: VM Products not working anymore after Joomla update
Post by: MAD King on March 24, 2015, 20:48:52 PM
Thank you Milbo, again. I am not a programmer, just an end user, and it is somehow frustrating when something worked before and after just one update you have to check everything to make sure all the third party modules working together.
Title: Re: VM Products not working anymore after Joomla update
Post by: bazmahti on April 05, 2015, 04:25:29 AM
I have the same annoying problem reported widely - upgraded to 3.4.1 and can no longer save virtuemart products, which completely stalls the project . Tried  uploading the J3.4.0 version of  the validate.js and validate-uncompressed.js files as advised, but this made no difference. I am hesitant to use the fix offered under "Syntax error, unrecognized expression: #mprices[product_price_publish_up]" as I am not getting that error message - I just get no result from clicking "save" after entering the data into the product fields - can only cancel out. Can anyone advise whether a simple fix has been found - it's very confusing trying to solve this via the various  threads?
Title: Re: VM Products not working anymore after Joomla update
Post by: Milbo on April 05, 2015, 08:57:29 AM
load vm3.0.6.4 or vm3.0.7
Title: Re: VM Products not working anymore after Joomla update
Post by: MAD King on April 08, 2015, 15:22:31 PM
3.0.6.4 has cart issues  with Joomla 3.4.1 and VM 3.0.7 is not stable yet.
Title: Re: VM Products not working anymore after Joomla update
Post by: Milbo on April 08, 2015, 17:01:01 PM
I could have named vm3.0.7 also 3.0.6.6.

All the numbering is by logic just theory.
Title: Re: VM Products not working anymore after Joomla update
Post by: Milbo on April 08, 2015, 17:06:44 PM
btw "3.0.6.4 has cart issues"

You are the only one. Vm3.0.7 had just only two issues so far and this is solved.

http://forum.virtuemart.net/index.php?topic=129246.msg444769#msg444769
http://forum.virtuemart.net/index.php?topic=129249.msg444770#msg444770