VirtueMart Forum

VirtueMart 2 + 3 + 4 => Virtuemart Development and bug reports => Development & Testing => Topic started by: nzed on June 18, 2014, 16:50:21 PM

Title: VM 2.9.7 Missing asterisk for required fields on account maintenance page
Post by: nzed on June 18, 2014, 16:50:21 PM
On page /index.php/shop/account-maintenance the shopper information Joomla fields are missing the asterisk mark (see register.png) however they are set as required in admin (see admin.png). When I am logged in it gets right, asterisks are shown (logged-in.png).

[attachment cleanup by admin]
Title: Re: VM 2.9.7 Missing asterisk for required fields on account maintenance page
Post by: lindapowers on June 18, 2014, 18:21:56 PM
This is and old issue carried from previous versions to which no one really seem to find a suitable solution http://forum.virtuemart.net/index.php?topic=119721.msg407436#msg407436
Title: Re: VM 2.9.7 Missing asterisk for required fields on account maintenance page
Post by: GJC Web Design on June 18, 2014, 19:39:24 PM
from memory this is the fix : http://forum.virtuemart.net/index.php?topic=119721.msg407954#msg407954
never made it to the core though - might be a bit outdated for 2.6.6
Title: Re: VM 2.9.7 Missing asterisk for required fields on account maintenance page
Post by: Milbo on June 18, 2014, 20:50:08 PM
They are not marked with asterisk, because you can checkout as guest and then you do not need to fill them
Title: Re: VM 2.9.7 Missing asterisk for required fields on account maintenance page
Post by: GJC Web Design on June 18, 2014, 23:30:38 PM
but only if you enable guest check out - of all the VM shops I've done not a single client has wanted guest checkout enabled

from memory (although it was a while ago) my hack deals with this - only adding an asterisk if guest checkout ISN'T enabled

Title: Re: VM 2.9.7 Missing asterisk for required fields on account maintenance page
Post by: Milbo on June 19, 2014, 07:54:23 AM
Funny, there are a lot people who disable registration. yepp, I never saw the hack, but yes it reliefs abit the problem. Actually I wrote it another solution already for vm3, please test there.
Title: Re: VM 2.9.7 Missing asterisk for required fields on account maintenance page
Post by: jenkinhill on June 19, 2014, 11:13:26 AM
The last 3 VM sites I built use only guest registration.......
Title: Re: VM 2.9.7 Missing asterisk for required fields on account maintenance page
Post by: GJC Web Design on June 19, 2014, 11:42:29 AM
Strange clients u have - all my clients want to build a close and loving relationship with their customers and spam them to hell with special offers, newsletter blah blah and so forth...  ;D
Title: Re: VM 2.9.7 Missing asterisk for required fields on account maintenance page
Post by: nzed on June 19, 2014, 15:06:34 PM
Quote from: Milbo on June 19, 2014, 07:54:23 AM
Actually I wrote it another solution already for vm3, please test there.

Where can I find that ?
Title: Re: VM 2.9.7 Missing asterisk for required fields on account maintenance page
Post by: GJC Web Design on June 19, 2014, 15:10:14 PM
these are ONLY TEST VERSIONS!!!!!!!!!!!!!!!!!!

http://dev.virtuemart.net/attachments/download/758/com_virtuemart.2.9.7_extract_first.zip
Title: Re: VM 2.9.7 Missing asterisk for required fields on account maintenance page
Post by: nzed on June 19, 2014, 15:12:46 PM
Quote from: GJC Web Design on June 19, 2014, 15:10:14 PM
http://dev.virtuemart.net/attachments/download/758/com_virtuemart.2.9.7_extract_first.zip

This is the version where I have found the problem.
Title: Re: VM 2.9.7 Missing asterisk for required fields on account maintenance page
Post by: GJC Web Design on June 19, 2014, 16:29:50 PM
he he... have you tried my hack then?

http://forum.virtuemart.net/index.php?topic=119721.msg407954#msg407954
Title: Re: VM 2.9.7 Missing asterisk for required fields on account maintenance page
Post by: Milbo on June 20, 2014, 00:51:04 AM
Hmm strange, I use

if($register and $type == 'BT'  and VmConfig::get('oncheckout_show_register',1) ){

But yes I missed the fix for the password fields. Thanks for that, maybe now it works?
Title: Re: VM 2.9.7 Missing asterisk for required fields on account maintenance page
Post by: nzed on June 20, 2014, 09:10:25 AM
Quote from: GJC Web Design on June 19, 2014, 16:29:50 PM
he he... have you tried my hack then?

To be honest I am looking forward to having it in the official version ;-)
And please tell me where is that secret place where I can find the amended version. Seems like everyone knows here but me.  :-[
Title: Re: VM 2.9.7 Missing asterisk for required fields on account maintenance page
Post by: GJC Web Design on June 20, 2014, 09:54:50 AM
You can get involved in testing the 2.9 series for J3 by pm'ing Milbo - but all the latest test versions are at http://dev.virtuemart.net/projects/virtuemart/files
it's no secret