VirtueMart Forum

VirtueMart 2 + 3 + 4 => Virtuemart Development and bug reports => Topic started by: konstantin-shkodskih on December 19, 2012, 07:19:00 AM

Title: Missing $encoding argument in htmlentities() inside default_addtocart.php
Post by: konstantin-shkodskih on December 19, 2012, 07:19:00 AM
Version: 2.0.15f
File: \components\com_virtuemart\views\productdetails\tmpl\default_addtocart.php
String number: 100
Code: <input type="hidden" class="pname" value="<?php echo htmlentities($this->product->product_name) ?>"/>
Notice: missing $encoding argument in function htmlentities(). For this reason, the name of the product in a language other than English (eg Russian) is not properly displayed.
Title: Re: Missing $encoding argument in htmlentities() inside default_addtocart.php
Post by: Milbo on December 19, 2012, 11:03:36 AM
This is already in the latest version F, I just added that 2 days ago
Title: Re: Missing $encoding argument in htmlentities() inside default_addtocart.php
Post by: konstantin-shkodskih on January 04, 2013, 03:23:12 AM
Thanks! I see that added to version 2.0.16b:
Quotehtmlentities(..., ENT_QUOTES, 'utf-8')
- i meant $encoding parameter.
Title: Re: Missing $encoding argument in htmlentities() inside default_addtocart.php
Post by: bytelord on January 06, 2013, 17:07:31 PM
Hello,

I have added before 15 days in 2.1 trunk, i think is already in 2.0.16a/b but not sure...

http://forum.virtuemart.net/index.php?topic=111359.msg374103#msg374103
Title: Re: Missing $encoding argument in htmlentities() inside default_addtocart.php
Post by: Milbo on January 06, 2013, 17:28:36 PM
He says thank you for adding it.
Title: Re: Missing $encoding argument in htmlentities() inside default_addtocart.php
Post by: bytelord on January 06, 2013, 17:48:16 PM
lol :) i have too many days to login that i missed some things :)