News:

Support the VirtueMart project and become a member

Main Menu

Big Bug found ^^

Started by DJ_Baer, February 05, 2012, 18:46:09 PM

Previous topic - Next topic

DJ_Baer

good morning the ladies  :-*  ^^

Validation Output: 1 Error

Error Line 290, Column 23: there is no attribute "ID"

    <ul class="VMmenu" ID="vmmenu288_1069" >


By Joomla 2.5.1/ vm 2.0.1d / aio In the modules/mod_virtuemart_category/tmpl/default.php is a not valide code

Please edit the code with big ID:

<ul class="VMmenu<?php echo $class_sfx ?>" ID="<?php echo "vmmenu".$ID ?>" >

to small id:

<ul class="VMmenu<?php echo $class_sfx ?>" id="<?php echo "vmmenu".$ID ?>" >

I wish you a good run for development of vm 2 for Joomla 2.5.

Greeting Ba3r

DJ_Baer

The next unvalide code in components/com_virtuemart/helpers/config.php

line:821

$jsVars  .= "vmLang = '&lang=". substr(VMLANG,0,2) ."' ;\n" ;

change to:

$jsVars  .= "vmLang = '&amp;lang=". substr(VMLANG,0,2) ."' ;\n" ;


DJ_Baer

#2
No 3:

Line 751, Column 11: ID "bottom-pagination" already defined

   <div id="bottom-pagination"><span style="float:right"></span></div>

is not valide, 1 id Only 1 can be used once. Or use class.

Fix for me:
In components/com_virtuemart/views/category/tmpl/default.php

change one of two    <div id="bottom-pagination"> to <div id="bottom-pagination1">

change in components/com_virtuemart/assets/css/vmsite-ltr.css

#bottom-pagination div{text-align:center !important;}
#bottom-pagination ul{text-align:center !important;}
#bottom-pagination ul li{display: inline;}
#bottom-pagination  .counter{text-align: right !important;}


to

#bottom-pagination div, #bottom-pagination1 div{text-align:center !important;}
#bottom-pagination ul, #bottom-pagination1 ul{text-align:center !important;}
#bottom-pagination ul li, #bottom-pagination1 ul li{display: inline;}
#bottom-pagination  .counter, #bottom-pagination1  .counter{text-align: right !important;}



DJ_Baer

No4:

Line 433, Column 147: character data is not allowed here

...1" onchange="window.top.location.href=this.options[this.selectedIndex].value">>
change:
in administrator/components/com_virtuemart/helpers/vmmodel.php Zeile:717

$js = 'onchange="window.top.location.href=this.options[this.selectedIndex].value">';

to

$js = 'onchange="window.top.location.href=this.options[this.selectedIndex].value"';

DJ_Baer

Line 39, Column 55: document type does not allow element "div" here

...div id="facebox" style="display:none;"><div class="popup"><div class="content"...

in administrator/components/com_virtuemart/helpers/config.php Line 824

$jsVars .= "faceboxHtml = \"<div id='facebox' style='display:none;'><div class='popup'><div class='content'></div> <a href='#' class='close'><img src='".$closeimage."' title='close' class='close_image' /></a></div></div>\" ;\n";

change to Line: 818

$jsVars .= '<!-- faceboxHtml = \'<div id="facebox" style="display:none;"><div class="popup"><div class="content"></div> <a href="#" class="close"><img src="'.$closeimage.'" title="close" alt="X" class="close_image" /></a></div></div>\'  -->'."\n";




DJ_Baer

Line 447, Column 37: cannot generate system identifier for general entity "option"

      <a href="index.php?tmpl=component&option=com_virtuemart&view=productdetails&v...

in components/com_virtuemart/views/productdetails/tmpl/default.php in all Link ( component&option ) the & changen to &amp;

see here:

index.php?option=com_virtuemart&view=productdetails&task=askquestion&virtuemart_product_id

to

index.php?option=com_virtuemart&amp;view=productdetails&amp;task=askquestion&amp;virtuemart_product_id

I have override this file in templates/my_Template/html/com_virtuemart/productdetails/default.php .

slammy

Hi,

thx for ur work to get valid xhtml1.0 code for my store!

regards slammy

Milbo

Thanks, added.

But I am not certain about the links, because the joomla router should do it, or? and it does not appear imho, when sef is used.

and this here is unclear for me

Quote from: DJ_Baer on February 05, 2012, 21:33:14 PM
Line 39, Column 55: document type does not allow element "div" here

...div id="facebox" style="display:none;"><div class="popup"><div class="content"...

in administrator/components/com_virtuemart/helpers/config.php Line 824

$jsVars .= "faceboxHtml = \"<div id='facebox' style='display:none;'><div class='popup'><div class='content'></div> <a href='#' class='close'><img src='".$closeimage."' title='close' class='close_image' /></a></div></div>\" ;\n";

change to Line: 818

$jsVars .= '<!-- faceboxHtml = \'<div id="facebox" style="display:none;"><div class="popup"><div class="content"></div> <a href="#" class="close"><img src="'.$closeimage.'" title="close" alt="X" class="close_image" /></a></div></div>\'  -->'."\n";



Should I fix your bug, please support the VirtueMart project and become a member
______________________________________
Extensions approved by the core team: http://extensions.virtuemart.net/